opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: use random names for TestUpdateUserProfile (#15868)

Browse Source 
Fixes a flake seen in
https://github.com/coder/coder/actions/runs/12346801529/job/34452940351
It's possible but exceedingly rare for the randomly generated username
to be exactly 32 characters.
Then, appending a `1` to that username causes the username to be invalid
and the test to fail. Instead of appending we'll just generate a new
username that is <=32 characters.

The `UpdateSelf` subtest has the same appending, but uses a fixed
username that is less than 32 characters, so it doesn't need to be
changed.
This commit is contained in:
Ethan
2024-12-16 06:59:44 +00:00
committed by GitHub
parent c92f480fcf
commit 409e2c7a20
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
coderd/users_test.go
+7 -5
View File
@@ -1005,22 +1005,24 @@ func TestUpdateUserProfile(t *testing.T) {
firstUser := coderdtest.CreateFirstUser(t, client) firstUser := coderdtest.CreateFirstUser(t, client)
numLogs++ // add an audit log for login numLogs++ // add an audit log for login
memberClient, memberUser := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID) memberClient, _ := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID)
numLogs++ // add an audit log for user creation numLogs++ // add an audit log for user creation
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel() defer cancel()
newUsername := coderdtest.RandomUsername(t)
newName := coderdtest.RandomName(t)
userProfile, err := memberClient.UpdateUserProfile(ctx, codersdk.Me, codersdk.UpdateUserProfileRequest{ userProfile, err := memberClient.UpdateUserProfile(ctx, codersdk.Me, codersdk.UpdateUserProfileRequest{
Username: memberUser.Username + "1", Username: newUsername,
Name: memberUser.Name + "1", Name: newName,
}) })
numLogs++ // add an audit log for user update numLogs++ // add an audit log for user update
numLogs++ // add an audit log for API key creation numLogs++ // add an audit log for API key creation
require.NoError(t, err) require.NoError(t, err)
require.Equal(t, memberUser.Username+"1", userProfile.Username) require.Equal(t, newUsername, userProfile.Username)
require.Equal(t, memberUser.Name+"1", userProfile.Name) require.Equal(t, newName, userProfile.Name)
require.Len(t, auditor.AuditLogs(), numLogs) require.Len(t, auditor.AuditLogs(), numLogs)
require.Equal(t, database.AuditActionWrite, auditor.AuditLogs()[numLogs-1].Action) require.Equal(t, database.AuditActionWrite, auditor.AuditLogs()[numLogs-1].Action)