From 3bd32a2e2a7fb023d36ada0f49987930d52efd44 Mon Sep 17 00:00:00 2001
From: Cian Johnston <cian@coder.com>
Date: Thu, 20 Mar 2025 14:44:30 +0000
Subject: [PATCH] chore(cli): wait for agent to connect before dialing it in
 TestExpRpty (#17026)

Fixes flake seen here:
https://github.com/coder/coder/actions/runs/13970861685/job/39113344525
---
 cli/exp_rpty_test.go | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/cli/exp_rpty_test.go b/cli/exp_rpty_test.go
index 5089796f5a..b7f26beb87 100644
--- a/cli/exp_rpty_test.go
+++ b/cli/exp_rpty_test.go
@@ -33,14 +33,14 @@ func TestExpRpty(t *testing.T) {
 
 		ctx := testutil.Context(t, testutil.WaitLong)
 
+		_ = agenttest.New(t, client.URL, agentToken)
+		_ = coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
+
 		cmdDone := tGo(t, func() {
 			err := inv.WithContext(ctx).Run()
 			assert.NoError(t, err)
 		})
 
-		_ = agenttest.New(t, client.URL, agentToken)
-		_ = coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
-
 		pty.WriteLine("exit")
 		<-cmdDone
 	})
@@ -56,14 +56,14 @@ func TestExpRpty(t *testing.T) {
 
 		ctx := testutil.Context(t, testutil.WaitLong)
 
+		_ = agenttest.New(t, client.URL, agentToken)
+		_ = coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
+
 		cmdDone := tGo(t, func() {
 			err := inv.WithContext(ctx).Run()
 			assert.NoError(t, err)
 		})
 
-		_ = agenttest.New(t, client.URL, agentToken)
-		_ = coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
-
 		pty.ExpectMatch(randStr)
 		<-cmdDone
 	})