From 3b07f7b9c4180da9dc9bd1f816317811575c385c Mon Sep 17 00:00:00 2001 From: "blinkagent[bot]" <237617714+blinkagent[bot]@users.noreply.github.com> Date: Fri, 16 Jan 2026 10:48:20 +0200 Subject: [PATCH] fix: remove unreachable exit after error call in check_pg_schema.sh (#21530) Fixes shellcheck warning reported in https://github.com/coder/coder/pull/21496#discussion_r2696470065 ## Problem The `error()` function in `lib.sh` already calls `exit 1`, so the `exit 1` on line 17 of `check_pg_schema.sh` was unreachable: ``` In ./scripts/check_pg_schema.sh line 17: exit 1 ^----^ SC2317 (info): Command appears to be unreachable. ``` ## Solution Remove the redundant `exit 1` since `error()` already handles exiting. Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com> --- scripts/check_pg_schema.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/check_pg_schema.sh b/scripts/check_pg_schema.sh index 59d25aba97..994f94a950 100755 --- a/scripts/check_pg_schema.sh +++ b/scripts/check_pg_schema.sh @@ -14,7 +14,6 @@ cdroot if [[ $# -lt 1 ]]; then error "Usage: check_pg_schema.sh