mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
chore: remove coder trace telemetry (#9677)
This commit is contained in:
@@ -105,7 +105,6 @@ func (s *scaletestTracingFlags) provider(ctx context.Context) (trace.TracerProvi
|
||||
|
||||
tracerProvider, closeTracing, err := tracing.TracerProvider(ctx, scaletestTracerName, tracing.TracerOpts{
|
||||
Default: s.traceEnable,
|
||||
Coder: s.traceCoder,
|
||||
Honeycomb: s.traceHoneycombAPIKey,
|
||||
})
|
||||
if err != nil {
|
||||
|
||||
@@ -7,7 +7,6 @@ import (
|
||||
"encoding/base64"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"flag"
|
||||
"fmt"
|
||||
"io"
|
||||
"math/rand"
|
||||
@@ -436,10 +435,6 @@ func LoggerFromContext(ctx context.Context) (slog.Logger, bool) {
|
||||
return l, ok
|
||||
}
|
||||
|
||||
func isTest() bool {
|
||||
return flag.Lookup("test.v") != nil
|
||||
}
|
||||
|
||||
// RootCmd contains parameters and helpers useful to all commands.
|
||||
type RootCmd struct {
|
||||
clientURL *url.URL
|
||||
|
||||
+2
-12
@@ -408,7 +408,7 @@ func (r *RootCmd) Server(newAPI func(context.Context, *coderd.Options) (*coderd.
|
||||
// which is caught by goleaks.
|
||||
defer http.DefaultClient.CloseIdleConnections()
|
||||
|
||||
tracerProvider, sqlDriver, closeTracing := ConfigureTraceProvider(ctx, logger, inv, vals)
|
||||
tracerProvider, sqlDriver, closeTracing := ConfigureTraceProvider(ctx, logger, vals)
|
||||
defer func() {
|
||||
logger.Debug(ctx, "closing tracing")
|
||||
traceCloseErr := shutdownWithTimeout(closeTracing, 5*time.Second)
|
||||
@@ -2087,7 +2087,6 @@ func (s *HTTPServers) Close() {
|
||||
func ConfigureTraceProvider(
|
||||
ctx context.Context,
|
||||
logger slog.Logger,
|
||||
inv *clibase.Invocation,
|
||||
cfg *codersdk.DeploymentValues,
|
||||
) (trace.TracerProvider, string, func(context.Context) error) {
|
||||
var (
|
||||
@@ -2095,19 +2094,10 @@ func ConfigureTraceProvider(
|
||||
closeTracing = func(context.Context) error { return nil }
|
||||
sqlDriver = "postgres"
|
||||
)
|
||||
// Coder tracing should be disabled if telemetry is disabled unless
|
||||
// --telemetry-trace was explicitly provided.
|
||||
shouldCoderTrace := cfg.Telemetry.Enable.Value() && !isTest()
|
||||
// Only override if telemetryTraceEnable was specifically set.
|
||||
// By default we want it to be controlled by telemetryEnable.
|
||||
if inv.ParsedFlags().Changed("telemetry-trace") {
|
||||
shouldCoderTrace = cfg.Telemetry.Trace.Value()
|
||||
}
|
||||
|
||||
if cfg.Trace.Enable.Value() || shouldCoderTrace || cfg.Trace.HoneycombAPIKey != "" {
|
||||
if cfg.Trace.Enable.Value() || cfg.Trace.DataDog.Value() || cfg.Trace.HoneycombAPIKey != "" {
|
||||
sdkTracerProvider, _closeTracing, err := tracing.TracerProvider(ctx, "coderd", tracing.TracerOpts{
|
||||
Default: cfg.Trace.Enable.Value(),
|
||||
Coder: shouldCoderTrace,
|
||||
DataDog: cfg.Trace.DataDog.Value(),
|
||||
Honeycomb: cfg.Trace.HoneycombAPIKey.String(),
|
||||
})
|
||||
|
||||
-5
@@ -415,11 +415,6 @@ telemetrywhen required by your organization's security policy.
|
||||
Whether telemetry is enabled or not. Coder collects anonymized usage
|
||||
data to help improve our product.
|
||||
|
||||
[96m--[0m[96mtelemetry-trace[0m bool, [96m$CODER_TELEMETRY_TRACE[0m (default: false)
|
||||
Whether Opentelemetry traces are sent to Coder. Coder collects
|
||||
anonymized application tracing to help improve our product. Disabling
|
||||
telemetry also disables this option.
|
||||
|
||||
[93mUSER QUIET HOURS SCHEDULE OPTIONS:[0m
|
||||
Allow users to set quiet hours schedules each day for workspaces to avoid
|
||||
workspaces stopping during the day due to template max TTL.
|
||||
|
||||
-5
@@ -334,11 +334,6 @@ telemetry:
|
||||
# help improve our product.
|
||||
# (default: false, type: bool)
|
||||
enable: false
|
||||
# Whether Opentelemetry traces are sent to Coder. Coder collects anonymized
|
||||
# application tracing to help improve our product. Disabling telemetry also
|
||||
# disables this option.
|
||||
# (default: false, type: bool)
|
||||
trace: false
|
||||
# URL to send telemetry.
|
||||
# (default: https://telemetry.coder.com, type: url)
|
||||
url: https://telemetry.coder.com
|
||||
|
||||
Reference in New Issue
Block a user