chore: join owner, template, and org in new workspace view (#15116)

Joins in fields like `username`, `avatar_url`, `organization_name`,
`template_name` to `workspaces` via a **view**. 
The view must be maintained moving forward, but this prevents needing to
add RBAC permissions to fetch related workspace fields.

coderd/httpmw/workspaceagent.go

@@ -110,7 +110,7 @@ func ExtractWorkspaceAgentAndLatestBuild(opts ExtractWorkspaceAgentAndLatestBuil
 			}
 
 			//nolint:gocritic // System needs to be able to get owner roles.
-			roles, err := opts.DB.GetAuthorizationUserRoles(dbauthz.AsSystemRestricted(ctx), row.Workspace.OwnerID)
+			roles, err := opts.DB.GetAuthorizationUserRoles(dbauthz.AsSystemRestricted(ctx), row.WorkspaceTable.OwnerID)
 			if err != nil {
 				httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
 					Message: "Internal error checking workspace agent authorization.",
@@ -129,13 +129,13 @@ func ExtractWorkspaceAgentAndLatestBuild(opts ExtractWorkspaceAgentAndLatestBuil
 			}
 
 			subject := rbac.Subject{
-				ID:     row.Workspace.OwnerID.String(),
+				ID:     row.WorkspaceTable.OwnerID.String(),
 				Roles:  rbac.RoleIdentifiers(roleNames),
 				Groups: roles.Groups,
 				Scope: rbac.WorkspaceAgentScope(rbac.WorkspaceAgentScopeParams{
-					WorkspaceID: row.Workspace.ID,
-					OwnerID:     row.Workspace.OwnerID,
-					TemplateID:  row.Workspace.TemplateID,
+					WorkspaceID: row.WorkspaceTable.ID,
+					OwnerID:     row.WorkspaceTable.OwnerID,
+					TemplateID:  row.WorkspaceTable.TemplateID,
 					VersionID:   row.WorkspaceBuild.TemplateVersionID,
 				}),
 			}.WithCachedASTValue()

coderd/httpmw/workspaceagent_test.go

@@ -97,7 +97,7 @@ func TestWorkspaceAgent(t *testing.T) {
 	})
 }
 
-func setup(t testing.TB, db database.Store, authToken uuid.UUID, mw func(http.Handler) http.Handler) (*http.Request, http.Handler, database.Workspace, database.TemplateVersion) {
+func setup(t testing.TB, db database.Store, authToken uuid.UUID, mw func(http.Handler) http.Handler) (*http.Request, http.Handler, database.WorkspaceTable, database.TemplateVersion) {
 	t.Helper()
 	org := dbgen.Organization(t, db, database.Organization{})
 	user := dbgen.User(t, db, database.User{
@@ -116,7 +116,7 @@ func setup(t testing.TB, db database.Store, authToken uuid.UUID, mw func(http.Ha
 		ActiveVersionID: templateVersion.ID,
 		CreatedBy:       user.ID,
 	})
-	workspace := dbgen.Workspace(t, db, database.Workspace{
+	workspace := dbgen.Workspace(t, db, database.WorkspaceTable{
 		OwnerID:        user.ID,
 		OrganizationID: org.ID,
 		TemplateID:     template.ID,

coderd/httpmw/workspaceagentparam_test.go

@@ -31,7 +31,7 @@ func TestWorkspaceAgentParam(t *testing.T) {
 				UserID: user.ID,
 			})
 			tpl       = dbgen.Template(t, db, database.Template{})
-			workspace = dbgen.Workspace(t, db, database.Workspace{
+			workspace = dbgen.Workspace(t, db, database.WorkspaceTable{
 				OwnerID:    user.ID,
 				TemplateID: tpl.ID,
 			})

coderd/httpmw/workspacebuildparam_test.go

@@ -20,13 +20,13 @@ import (
 func TestWorkspaceBuildParam(t *testing.T) {
 	t.Parallel()
 
-	setupAuthentication := func(db database.Store) (*http.Request, database.Workspace) {
+	setupAuthentication := func(db database.Store) (*http.Request, database.WorkspaceTable) {
 		var (
 			user     = dbgen.User(t, db, database.User{})
 			_, token = dbgen.APIKey(t, db, database.APIKey{
 				UserID: user.ID,
 			})
-			workspace = dbgen.Workspace(t, db, database.Workspace{
+			workspace = dbgen.Workspace(t, db, database.WorkspaceTable{
 				OwnerID: user.ID,
 			})
 		)

coderd/httpmw/workspaceparam_test.go

@@ -355,7 +355,7 @@ func setupWorkspaceWithAgents(t testing.TB, cfg setupConfig) (database.Store, *h
 		_, token = dbgen.APIKey(t, db, database.APIKey{
 			UserID: user.ID,
 		})
-		workspace = dbgen.Workspace(t, db, database.Workspace{
+		workspace = dbgen.Workspace(t, db, database.WorkspaceTable{
 			OwnerID: user.ID,
 			Name:    cfg.WorkspaceName,
 		})