From 33a04f661f94b23522593935ff85d0d3b9de8a51 Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Mon, 27 Jun 2022 09:57:37 -0500 Subject: [PATCH] fix: Check if start is nil before consuming in echo provisioner (#2686) This caused a race seen here: https://github.com/coder/coder/runs/7074123929?check_suite_focus=true#step:10:217 --- provisioner/echo/serve.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/provisioner/echo/serve.go b/provisioner/echo/serve.go index 1e5b01e4ad..70c10b548b 100644 --- a/provisioner/echo/serve.go +++ b/provisioner/echo/serve.go @@ -82,6 +82,10 @@ func (e *echo) Provision(stream proto.DRPCProvisioner_ProvisionStream) error { return err } request := msg.GetStart() + if request == nil { + // A cancel could occur here! + return nil + } for index := 0; ; index++ { extension := ".protobuf" if request.DryRun {