From 30afe43f8a9f6b7b04ba1711e1413906551bf17e Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Wed, 3 Jan 2024 13:18:15 -0600 Subject: [PATCH] fix: create tempdir prior to cleanup (#11394) See https://github.com/coder/coder/actions/runs/7399827933/job/20132407700 Seems like this happened because the test was being cleaned up while the tempdir was being made. --- provisionerd/provisionerd_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/provisionerd/provisionerd_test.go b/provisionerd/provisionerd_test.go index c4a173a79e..a04196e6b4 100644 --- a/provisionerd/provisionerd_test.go +++ b/provisionerd/provisionerd_test.go @@ -1137,12 +1137,13 @@ func createProvisionerClient(t *testing.T, done <-chan struct{}, server provisio }) ctx, cancelFunc := context.WithCancel(context.Background()) closed := make(chan struct{}) + tempDir := t.TempDir() go func() { defer close(closed) _ = provisionersdk.Serve(ctx, &server, &provisionersdk.ServeOptions{ Listener: serverPipe, Logger: slogtest.Make(t, nil).Leveled(slog.LevelDebug).Named("test-provisioner"), - WorkDirectory: t.TempDir(), + WorkDirectory: tempDir, }) }() t.Cleanup(func() {