From 2f8b056e271df2ac57704585789b13079922174f Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Thu, 5 Jun 2025 17:53:35 +0300 Subject: [PATCH] test(agent/agentcontainers): fix test data race due to list manipulation (#18250) Fixes coder/internal#675 --- agent/agentcontainers/api.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/agent/agentcontainers/api.go b/agent/agentcontainers/api.go index 349b85e3d2..8fff664c0b 100644 --- a/agent/agentcontainers/api.go +++ b/agent/agentcontainers/api.go @@ -378,6 +378,8 @@ func (api *API) updateContainers(ctx context.Context) error { return xerrors.Errorf("list containers failed: %w", err) } + // Clone to avoid test flakes due to data manipulation. + updated.Containers = slices.Clone(updated.Containers) api.mu.Lock() defer api.mu.Unlock()