From 2d0a69ba473aba12527ca0137e68ac978a7e9d74 Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Mon, 13 Feb 2023 18:46:05 -0600 Subject: [PATCH] fix: require client pipe to be closed in provisionerd test (#6188) https://github.com/coder/coder/actions/runs/4165019548/jobs/7207442687 --- provisionerd/provisionerd_test.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/provisionerd/provisionerd_test.go b/provisionerd/provisionerd_test.go index 44884800fa..fa42f66a25 100644 --- a/provisionerd/provisionerd_test.go +++ b/provisionerd/provisionerd_test.go @@ -1090,10 +1090,16 @@ func createProvisionerDaemonClient(t *testing.T, server provisionerDaemonTestSer require.NoError(t, err) srv := drpcserver.New(mux) ctx, cancelFunc := context.WithCancel(context.Background()) - t.Cleanup(cancelFunc) + closed := make(chan struct{}) go func() { + defer close(closed) _ = srv.Serve(ctx, serverPipe) }() + t.Cleanup(func() { + cancelFunc() + _ = serverPipe.Close() + <-closed + }) return proto.NewDRPCProvisionerDaemonClient(clientPipe) }