opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix(coderd): explain default GitHub app org visibility on login rejection" (#27388)

Browse Source
This commit is contained in:
Atif Ali
2026-07-21 16:17:27 +00:00
committed by GitHub
parent 48e9bb3391
commit 2b2a5c963a
4 changed files with 2 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli/server.go
+2 -12
View File
@@ -1006,7 +1006,7 @@ func (r *RootCmd) Server(newAPI func(context.Context, *coderd.Options) (*coderd.
}
options.WebPushDispatcher = webpusher
githubOAuth2ConfigParams, err := getGithubOAuth2ConfigParams(ctx, options.Logger, options.Database, vals)
githubOAuth2ConfigParams, err := getGithubOAuth2ConfigParams(ctx, options.Database, vals)
if err != nil {
return xerrors.Errorf("get github oauth2 config params: %w", err)
}
@@ -2213,7 +2213,7 @@ func maybeAppendDefaultGithubExternalAuthProvider(
}), nil
}
func getGithubOAuth2ConfigParams(ctx context.Context, logger slog.Logger, db database.Store, vals *codersdk.DeploymentValues) (*githubOAuth2ConfigParams, error) {
func getGithubOAuth2ConfigParams(ctx context.Context, db database.Store, vals *codersdk.DeploymentValues) (*githubOAuth2ConfigParams, error) {
params := githubOAuth2ConfigParams{
accessURL: vals.AccessURL.Value(),
clientID: vals.OAuth2.Github.ClientID.String(),
@@ -2250,16 +2250,6 @@ func getGithubOAuth2ConfigParams(ctx context.Context, logger slog.Logger, db dat
params.deviceFlow = GithubOAuth2DefaultProviderDeviceFlow
if len(params.allowOrgs) == 0 {
params.allowEveryone = GithubOAuth2DefaultProviderAllowEveryone
} else {
// The default provider is a GitHub App, which can only see memberships
// in organizations that have installed it. If the app isn't installed
// in an allowed organization, every login from that organization is
// rejected as "not a member".
logger.Warn(ctx, "the default GitHub OAuth provider can only see memberships in organizations that have installed the Coder GitHub app; "+
"users cannot log in until the app is installed in each allowed organization, or a custom GitHub OAuth app is configured",
slog.F("allowed_orgs", params.allowOrgs),
slog.F("install_url", coderd.GithubOAuth2DefaultProviderInstallURL),
)
}
return &params, nil