From 2a76f5028e457177267a3ca1a7f755b83a6972c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=82=B1=E3=82=A4=E3=83=A9?= Date: Wed, 16 Apr 2025 09:14:35 -0700 Subject: [PATCH] fix: don't attempt to insert empty terraform plans into the database (#17426) --- coderd/provisionerdserver/provisionerdserver.go | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go index 47fecfb4a1..a4e28741ce 100644 --- a/coderd/provisionerdserver/provisionerdserver.go +++ b/coderd/provisionerdserver/provisionerdserver.go @@ -1417,13 +1417,15 @@ func (s *server) CompleteJob(ctx context.Context, completed *proto.CompletedJob) return nil, xerrors.Errorf("update template version external auth providers: %w", err) } - err = s.Database.InsertTemplateVersionTerraformValuesByJobID(ctx, database.InsertTemplateVersionTerraformValuesByJobIDParams{ - JobID: jobID, - CachedPlan: jobType.TemplateImport.Plan, - UpdatedAt: now, - }) - if err != nil { - return nil, xerrors.Errorf("insert template version terraform data: %w", err) + if len(jobType.TemplateImport.Plan) > 0 { + err := s.Database.InsertTemplateVersionTerraformValuesByJobID(ctx, database.InsertTemplateVersionTerraformValuesByJobIDParams{ + JobID: jobID, + CachedPlan: jobType.TemplateImport.Plan, + UpdatedAt: now, + }) + if err != nil { + return nil, xerrors.Errorf("insert template version terraform data: %w", err) + } } err = s.Database.UpdateProvisionerJobWithCompleteByID(ctx, database.UpdateProvisionerJobWithCompleteByIDParams{