mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
chore(scripts/rules.go): broaden scope of testingWithOwnerUser linter (#10548)
* Updated testingWithOwnerUser ruleguard rule to detect: a) Passing client from coderdenttest.New() to clitest.SetupConfig() similar to what already exists for AGPL code b) Usage of any method of the owner client from coderdenttest.New() - all usages of the owner client must be justified with a `//nolint:gocritic` comment. * Fixed resulting linter complaints. * Added new coderdtest helpers CreateGroup and UpdateTemplateMeta. * Modified check_enterprise_import.sh to ignore scripts/rules.go.
This commit is contained in:
@@ -47,7 +47,7 @@ func TestCheckWarnings(t *testing.T) {
|
||||
|
||||
var buf bytes.Buffer
|
||||
inv.Stderr = &buf
|
||||
clitest.SetupConfig(t, client, conf)
|
||||
clitest.SetupConfig(t, client, conf) //nolint:gocritic // owners should see this
|
||||
|
||||
err := inv.Run()
|
||||
require.NoError(t, err)
|
||||
|
||||
Reference in New Issue
Block a user