From 242c4d791b97ac0b9d97d38fc57d30d524906d1b Mon Sep 17 00:00:00 2001 From: Michael Suchacz <203725896+ibetitsmike@users.noreply.github.com> Date: Thu, 4 Jun 2026 23:03:02 +0200 Subject: [PATCH] fix(coderd): isolate OIDC fake IDP in parallel subtests (#26075) --- coderd/userauth_test.go | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/coderd/userauth_test.go b/coderd/userauth_test.go index d9f5dabf49..e73a2e9354 100644 --- a/coderd/userauth_test.go +++ b/coderd/userauth_test.go @@ -1770,13 +1770,6 @@ func TestUserOIDC(t *testing.T) { t.Run("OIDCEmailFallbackBlockedByExistingLink", func(t *testing.T) { t.Parallel() - fake := oidctest.NewFakeIDP(t, - oidctest.WithRefresh(func(_ string) error { - return xerrors.New("refreshing token should never occur") - }), - oidctest.WithServing(), - ) - for _, tc := range []struct { name string allowSignups bool @@ -1788,6 +1781,12 @@ func TestUserOIDC(t *testing.T) { t.Run(tc.name, func(t *testing.T) { t.Parallel() + fake := oidctest.NewFakeIDP(t, + oidctest.WithRefresh(func(_ string) error { + return xerrors.New("refreshing token should never occur") + }), + oidctest.WithServing(), + ) cfg := fake.OIDCConfig(t, nil, func(cfg *coderd.OIDCConfig) { cfg.AllowSignups = tc.allowSignups })