mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
feat: smart file-based target selection for scripts/githooks (#23358)
Pre-commit classifies staged files and runs make pre-commit-light when no Go, TypeScript, or Makefile changes are present. This skips gen, lint/go, lint/ts, fmt/go, fmt/ts, and the binary build. A markdown-only commit takes seconds instead of minutes. Pre-push uses the same heuristic: if only light files changed (docs, shell, terraform, etc.), tests are skipped entirely. Falls back to the full make targets when Go/TS/Makefile changes are detected, CODER_HOOK_RUN_ALL=1 is set, or the diff range can't be determined. Also adds test-storybook to make pre-push (vitest with the storybook project in Playwright browser mode).
This commit is contained in:
@@ -1,9 +1,9 @@
|
||||
#!/usr/bin/env bash
|
||||
#
|
||||
# Pre-commit hook that runs CI-equivalent checks locally.
|
||||
# Runs `make pre-commit` (gen, fmt, lint, typos, build) which
|
||||
# catches most CI failures without needing Docker or Playwright.
|
||||
# Heavier checks (tests, site build) run via the pre-push hook.
|
||||
# Classifies staged files by type and only runs relevant make
|
||||
# targets. Falls back to the full `make pre-commit` when the
|
||||
# Makefile changed or CODER_HOOK_RUN_ALL=1 is set.
|
||||
#
|
||||
# Installation (worktree-compatible):
|
||||
#
|
||||
@@ -20,4 +20,21 @@ unset GIT_DIR
|
||||
if [[ "$(git rev-parse --git-dir)" != "$(git rev-parse --git-common-dir)" ]]; then
|
||||
git config --worktree core.hooksPath scripts/githooks
|
||||
fi
|
||||
exec make pre-commit
|
||||
|
||||
if [[ ${CODER_HOOK_RUN_ALL:-} == 1 ]]; then
|
||||
exec make pre-commit
|
||||
fi
|
||||
|
||||
staged=$(git diff --cached --name-only --diff-filter=d)
|
||||
if [[ -z $staged ]]; then
|
||||
echo "pre-commit: no staged changes, skipping"
|
||||
exit 0
|
||||
fi
|
||||
|
||||
# If Go, TS, or build-system files changed, run the full
|
||||
# pre-commit. Otherwise run the lightweight target that
|
||||
# covers everything except gen, Go/TS fmt+lint, and binary build.
|
||||
if echo "$staged" | grep -qE '\.(go|ts|tsx|sql|proto)$|^go\.(mod|sum)$|^site/|^Makefile$'; then
|
||||
exec make pre-commit
|
||||
fi
|
||||
exec make pre-commit-light
|
||||
|
||||
Reference in New Issue
Block a user