opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(coderd): scope provisioner module file downloads to the daemon's org (#26635)

Browse Source
This commit is contained in:
Jon Ayers
2026-06-24 12:09:22 -05:00
committed by GitHub
parent 9defdb4af2
commit 1961908ca7
9 changed files with 246 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
coderd/provisionerdserver/provisionerdserver.go
+20
View File
@@ -1584,6 +1584,26 @@ func (s *server) DownloadFile(request *proto.FileRequest, stream proto.DRPCProvi
if file.CreatedBy != uuid.Nil || file.Mimetype != tarMimeType {
return fail(xerrors.Errorf("file %s is not a modules file", fid))
}
// Ensure the requested module file belongs to a template version in
// this provisioner daemon's organization. Without this, any
// authenticated provisioner could download cached module archives
// (Terraform source) belonging to other organizations (ANT-2026-22440).
ok, err := s.Database.HasTemplateVersionsUsingCachedModuleFileInOrg(ctx, database.HasTemplateVersionsUsingCachedModuleFileInOrgParams{
FileID: fid,
OrganizationID: s.OrganizationID,
})
if err != nil {
return fail(xerrors.Errorf("authorize module file: %w", err))
}
if !ok {
s.Logger.Warn(ctx, "module file download rejected: file not referenced by any template version in daemon org",
slog.F("file_id", fid),
slog.F("organization_id", s.OrganizationID),
)
// Use the same error as the metadata check above so the handler
// does not confirm the existence of files in other organizations.
return fail(xerrors.Errorf("file %s is not a modules file", fid))
}
default:
return fail(xerrors.Errorf("unsupported file upload type: %s", request.UploadType))
}