chore: Add test helpers to improve coverage (#166)

* chore: Rename ProjectHistory to ProjectVersion Version more accurately represents version storage. This forks from the WorkspaceHistory name, but I think it's easier to understand Workspace history. * Rename files * Standardize tests a bit more * Remove Server struct from coderdtest * Improve test coverage for workspace history * Fix linting errors * Fix coderd test leak * Fix coderd test leak * Improve workspace history logs * Standardize test structure for codersdk * Fix linting errors * Fix WebSocket compression * Update coderd/workspaces.go Co-authored-by: Bryan <bryan@coder.com> * Add test for listing project parameters * Cache npm dependencies with setup node * Remove windows npm cache key Co-authored-by: Bryan <bryan@coder.com>
2026-09-24 15:04:27 +08:00 · 2022-02-05 18:24:51 -06:00
parent f19770b2c6
commit 1796dc6c2f
38 changed files with 1466 additions and 1057 deletions
@@ -10,61 +10,104 @@ import (
 	"github.com/coder/coder/coderd/coderdtest"
 )

-func TestUsers(t *testing.T) {
+func TestCreateInitialUser(t *testing.T) {
 	t.Parallel()
-	t.Run("CreateInitial", func(t *testing.T) {
+	t.Run("Error", func(t *testing.T) {
 		t.Parallel()
-		server := coderdtest.New(t)
-		_, err := server.Client.CreateInitialUser(context.Background(), coderd.CreateInitialUserRequest{
-			Email:        "wowie@coder.com",
-			Organization: "somethin",
-			Username:     "tester",
-			Password:     "moo",
-		})
-		require.NoError(t, err)
-	})
-
-	t.Run("NoUser", func(t *testing.T) {
-		t.Parallel()
-		server := coderdtest.New(t)
-		_, err := server.Client.User(context.Background(), "")
+		client := coderdtest.New(t)
+		_, err := client.CreateInitialUser(context.Background(), coderd.CreateInitialUserRequest{})
 		require.Error(t, err)
 	})

-	t.Run("User", func(t *testing.T) {
+	t.Run("Create", func(t *testing.T) {
 		t.Parallel()
-		server := coderdtest.New(t)
-		_ = server.RandomInitialUser(t)
-		_, err := server.Client.User(context.Background(), "")
-		require.NoError(t, err)
+		client := coderdtest.New(t)
+		_ = coderdtest.CreateInitialUser(t, client)
+	})
+}
+
+func TestCreateUser(t *testing.T) {
+	t.Parallel()
+	t.Run("Error", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t)
+		_, err := client.CreateUser(context.Background(), coderd.CreateUserRequest{})
+		require.Error(t, err)
 	})

-	t.Run("UserOrganizations", func(t *testing.T) {
+	t.Run("Create", func(t *testing.T) {
 		t.Parallel()
-		server := coderdtest.New(t)
-		_ = server.RandomInitialUser(t)
-		orgs, err := server.Client.UserOrganizations(context.Background(), "")
-		require.NoError(t, err)
-		require.Len(t, orgs, 1)
-	})
-
-	t.Run("LogoutIsSuccessful", func(t *testing.T) {
-		t.Parallel()
-		server := coderdtest.New(t)
-		_ = server.RandomInitialUser(t)
-		err := server.Client.Logout(context.Background())
-		require.NoError(t, err)
-	})
-
-	t.Run("CreateMultiple", func(t *testing.T) {
-		t.Parallel()
-		server := coderdtest.New(t)
-		_ = server.RandomInitialUser(t)
-		_, err := server.Client.CreateUser(context.Background(), coderd.CreateUserRequest{
-			Email:    "wow@ok.io",
-			Username: "example",
-			Password: "tomato",
+		client := coderdtest.New(t)
+		_ = coderdtest.CreateInitialUser(t, client)
+		_, err := client.CreateUser(context.Background(), coderd.CreateUserRequest{
+			Email:    "example@coder.com",
+			Username: "something",
+			Password: "password",
 		})
 		require.NoError(t, err)
 	})
 }
+
+func TestLoginWithPassword(t *testing.T) {
+	t.Parallel()
+	t.Run("Error", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t)
+		_, err := client.LoginWithPassword(context.Background(), coderd.LoginWithPasswordRequest{})
+		require.Error(t, err)
+	})
+
+	t.Run("Success", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t)
+		user := coderdtest.CreateInitialUser(t, client)
+		_, err := client.LoginWithPassword(context.Background(), coderd.LoginWithPasswordRequest{
+			Email:    user.Email,
+			Password: user.Password,
+		})
+		require.NoError(t, err)
+	})
+}
+
+func TestLogout(t *testing.T) {
+	t.Parallel()
+	client := coderdtest.New(t)
+	err := client.Logout(context.Background())
+	require.NoError(t, err)
+}
+
+func TestUser(t *testing.T) {
+	t.Parallel()
+	t.Run("Error", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t)
+		_, err := client.User(context.Background(), "")
+		require.Error(t, err)
+	})
+
+	t.Run("Get", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t)
+		_ = coderdtest.CreateInitialUser(t, client)
+		_, err := client.User(context.Background(), "")
+		require.NoError(t, err)
+	})
+}
+
+func TestUserOrganizations(t *testing.T) {
+	t.Parallel()
+	t.Run("Error", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t)
+		_, err := client.UserOrganizations(context.Background(), "")
+		require.Error(t, err)
+	})
+
+	t.Run("List", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t)
+		_ = coderdtest.CreateInitialUser(t, client)
+		_, err := client.UserOrganizations(context.Background(), "")
+		require.NoError(t, err)
+	})
+}