feat: add chat sharing foundation (#25041)

2026-09-24 15:04:27 +08:00 · 2026-05-18 22:32:05 +01:00
parent 2732378da2
commit 170a6e1fe9
49 changed files with 1872 additions and 103 deletions
@@ -12,6 +12,7 @@ import (
 	"github.com/coder/coder/v2/coderd/database/dbfake"
 	"github.com/coder/coder/v2/coderd/database/dbgen"
 	"github.com/coder/coder/v2/coderd/database/dbtestutil"
+	"github.com/coder/coder/v2/coderd/rbac/policy"
 	"github.com/coder/coder/v2/testutil"
 )

@@ -74,3 +75,85 @@ func TestActiveAgentChatDefinitionsAgree(t *testing.T) {
 		)
 	}
 }
+
+func TestActiveAgentChatsIncludeInheritedACLs(t *testing.T) {
+	t.Parallel()
+
+	ctx := dbauthz.AsSystemRestricted(testutil.Context(t, testutil.WaitMedium))
+	db, _, sqlDB := dbtestutil.NewDBWithSQLDB(t)
+
+	org, err := db.GetDefaultOrganization(ctx)
+	require.NoError(t, err)
+
+	owner := dbgen.User(t, db, database.User{})
+	workspace := dbfake.WorkspaceBuild(t, db, database.WorkspaceTable{
+		OrganizationID: org.ID,
+		OwnerID:        owner.ID,
+	}).WithAgent().Do()
+	modelConfig := insertAgentChatTestModelConfig(t, db, owner.ID)
+
+	root, err := db.InsertChat(ctx, database.InsertChatParams{
+		OrganizationID:    org.ID,
+		Status:            database.ChatStatusWaiting,
+		ClientType:        database.ChatClientTypeUi,
+		OwnerID:           owner.ID,
+		LastModelConfigID: modelConfig.ID,
+		Title:             "root-active-chat",
+		AgentID:           uuid.NullUUID{UUID: workspace.Agents[0].ID, Valid: true},
+	})
+	require.NoError(t, err)
+
+	child, err := db.InsertChat(ctx, database.InsertChatParams{
+		OrganizationID:    org.ID,
+		Status:            database.ChatStatusRunning,
+		ClientType:        database.ChatClientTypeUi,
+		OwnerID:           owner.ID,
+		LastModelConfigID: modelConfig.ID,
+		Title:             "child-active-chat",
+		AgentID:           uuid.NullUUID{UUID: workspace.Agents[0].ID, Valid: true},
+		ParentChatID:      uuid.NullUUID{UUID: root.ID, Valid: true},
+		RootChatID:        uuid.NullUUID{UUID: root.ID, Valid: true},
+	})
+	require.NoError(t, err)
+
+	rootUserACL := database.ChatACL{
+		owner.ID.String(): {Permissions: []policy.Action{policy.ActionRead, policy.ActionSSH}},
+	}
+	rootGroupACL := database.ChatACL{
+		org.ID.String(): {Permissions: []policy.Action{policy.ActionRead}},
+	}
+
+	userACLValue, err := rootUserACL.Value()
+	require.NoError(t, err)
+	groupACLValue, err := rootGroupACL.Value()
+	require.NoError(t, err)
+
+	_, err = sqlDB.ExecContext(
+		ctx,
+		`UPDATE chats SET user_acl = $1::jsonb, group_acl = $2::jsonb WHERE id = $3`,
+		userACLValue,
+		groupACLValue,
+		root.ID,
+	)
+	require.NoError(t, err)
+
+	activeChats, err := db.GetActiveChatsByAgentID(ctx, workspace.Agents[0].ID)
+	require.NoError(t, err)
+	require.Len(t, activeChats, 2)
+
+	activeByID := make(map[uuid.UUID]database.Chat, len(activeChats))
+	for _, chat := range activeChats {
+		activeByID[chat.ID] = chat
+	}
+
+	fetchedRoot, ok := activeByID[root.ID]
+	require.True(t, ok)
+	require.Equal(t, rootUserACL, fetchedRoot.UserACL)
+	require.Equal(t, rootGroupACL, fetchedRoot.GroupACL)
+
+	fetchedChild, ok := activeByID[child.ID]
+	require.True(t, ok)
+	require.True(t, fetchedChild.ParentChatID.Valid)
+	require.Equal(t, rootUserACL, fetchedChild.UserACL)
+	require.Equal(t, rootGroupACL, fetchedChild.GroupACL)
+}