opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Insert provisioner job logs async (#185)

Browse Source 
The context could be cancelled after a log is sent, which resulted
in a failure. This prevent's that from occurring by using the
background context.
This commit is contained in:
Kyle Carberry
2022-02-07 14:14:15 -08:00
committed by GitHub
parent d55231cc0f
commit 13360e2e2a
3 changed files with 7 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
coderd/provisionerdaemons.go
+1 -2
View File
@@ -305,9 +305,8 @@ func (server *provisionerdServer) UpdateJob(stream proto.DRPCProvisionerDaemon_U
insertParams.Source = append(insertParams.Source, logSource)
insertParams.Output = append(insertParams.Output, log.Output)
}
logs, err := server.Database.InsertProvisionerJobLogs(stream.Context(), insertParams)
logs, err := server.Database.InsertProvisionerJobLogs(context.Background(), insertParams)
if err != nil {
server.Logger.Error(stream.Context(), "insert provisioner job logs", slog.Error(err))
return xerrors.Errorf("insert job logs: %w", err)
}
data, err := json.Marshal(logs)