opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-22 05:05:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: only embed Azure roots on darwin (#25312)

Browse Source 
Partially reverts #25136 for non-darwin platforms.

In general we want to avoid pinning trust roots to embedded Certs, since that limits operational flexibility. If Azure changes CAs, operators should, at most, be able to update the OS trust store to keep Coder working correctly. Embedding roots means we need to upgrade the Coder binary.

Since Coder Server on macOS is not really supported for production use, embedding only in that case to ease development and testing is OK.
This commit is contained in:
Spike Curtis
2026-05-14 11:45:21 -04:00
committed by GitHub
parent e37bf4f7be
commit 132fa87bf3
6 changed files with 171 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/typos.toml
+2
View File
@@ -54,6 +54,8 @@ extend-exclude = [
"tailnet/testdata/**",
"site/src/pages/SetupPage/countries.tsx",
"provisioner/terraform/testdata/**",
"coderd/azureidentity/roots_darwin.go",
"coderd/azureidentity/azureidentity.go",
# notifications' golden files confuse the detector because of quoted-printable encoding
"coderd/notifications/testdata/**",
"agent/agentcontainers/testdata/devcontainercli/**",