chore(cli): fix issue with running individual sub-tests of Test_Tasks (#20646)

Closes https://github.com/coder/internal/issues/1112

Turns out sub-tests aren't ideal when you're running things that depend
on each other and need to be run in a certain order.
This commit is contained in:
Cian Johnston
2025-11-03 10:13:19 +00:00
committed by GitHub
parent 3d411ddf4c
commit 11f24119c5
+9 -11
View File
@@ -53,7 +53,6 @@ func Test_Tasks(t *testing.T) {
taskName = strings.ReplaceAll(testutil.GetRandomName(t), "_", "-")
)
//nolint:paralleltest // The sub-tests of this test must be run sequentially.
for _, tc := range []struct {
name string
cmdArgs []string
@@ -135,16 +134,15 @@ func Test_Tasks(t *testing.T) {
},
},
} {
t.Run(tc.name, func(t *testing.T) {
var stdout strings.Builder
inv, root := clitest.New(t, tc.cmdArgs...)
inv.Stdout = &stdout
clitest.SetupConfig(t, userClient, root)
require.NoError(t, inv.WithContext(ctx).Run())
if tc.assertFn != nil {
tc.assertFn(stdout.String(), userClient)
}
})
t.Logf("test case: %q", tc.name)
var stdout strings.Builder
inv, root := clitest.New(t, tc.cmdArgs...)
inv.Stdout = &stdout
clitest.SetupConfig(t, userClient, root)
require.NoError(t, inv.WithContext(ctx).Run(), tc.name)
if tc.assertFn != nil {
tc.assertFn(stdout.String(), userClient)
}
}
}