opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(agent): default process working directory to agent dir or $HOME (#23224)

Browse Source 
Processes started via the agent process API inherited the agent's
own working directory (/tmp/coder.xxx) when no WorkDir was
specified. SSH sessions already use a fallback chain: configured
agent directory > $HOME. This wires the same manifest directory
closure into the process manager so the priority is now:

  explicit req.WorkDir > agent configured dir > $HOME

The resolved directory is recorded on the process struct so
ProcessInfo.WorkDir and pathStore notifications reflect where
the process actually ran.
This commit is contained in:
Mathias Fredriksson
2026-03-18 16:46:26 +00:00
committed by GitHub
parent 483adc59fe
commit 119030d795
4 changed files with 151 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
agent/agentproc/api.go
+2 -2
View File
@@ -26,10 +26,10 @@ type API struct {
}
// NewAPI creates a new process API handler.
func NewAPI(logger slog.Logger, execer agentexec.Execer, updateEnv func(current []string) (updated []string, err error), pathStore *agentgit.PathStore) *API {
func NewAPI(logger slog.Logger, execer agentexec.Execer, updateEnv func(current []string) (updated []string, err error), pathStore *agentgit.PathStore, workingDir func() string) *API {
return &API{
logger: logger,
manager: newManager(logger, execer, updateEnv),
manager: newManager(logger, execer, updateEnv, workingDir),
pathStore: pathStore,
}
}