chore: change view perm to use (#4496)

This commit is contained in:
Jon Ayers
2022-10-12 14:33:21 -05:00
committed by GitHub
parent 47805643f7
commit 0fa8f528c2
7 changed files with 39 additions and 33 deletions
+1 -1
View File
@@ -916,7 +916,7 @@ export type ResourceType =
export type ServerSentEventType = "data" | "error" | "ping"
// From codersdk/templates.go
export type TemplateRole = "" | "admin" | "view"
export type TemplateRole = "" | "admin" | "use"
// From codersdk/users.go
export type UserStatus = "active" | "suspended"
@@ -51,14 +51,14 @@ const AddTemplateUserOrGroup: React.FC<AddTemplateUserOrGroupProps> = ({
const styles = useStyles()
const [selectedOption, setSelectedOption] =
useState<UserOrGroupAutocompleteValue>(null)
const [selectedRole, setSelectedRole] = useState<TemplateRole>("view")
const [selectedRole, setSelectedRole] = useState<TemplateRole>("use")
const excludeFromAutocomplete = templateACL
? [...templateACL.group, ...templateACL.users]
: []
const resetValues = () => {
setSelectedOption(null)
setSelectedRole("view")
setSelectedRole("use")
}
return (
@@ -89,7 +89,7 @@ const AddTemplateUserOrGroup: React.FC<AddTemplateUserOrGroupProps> = ({
/>
<Select
defaultValue="view"
defaultValue="use"
variant="outlined"
className={styles.select}
disabled={isLoading}
@@ -97,8 +97,8 @@ const AddTemplateUserOrGroup: React.FC<AddTemplateUserOrGroupProps> = ({
setSelectedRole(event.target.value as TemplateRole)
}}
>
<MenuItem key="view" value="view">
View
<MenuItem key="use" value="use">
Use
</MenuItem>
<MenuItem key="admin" value="admin">
Admin
@@ -129,17 +129,20 @@ const RoleSelect: FC<SelectProps> = (props) => {
className={styles.updateSelect}
{...props}
>
<MenuItem key="view" value="view" className={styles.menuItem}>
<MenuItem key="use" value="use" className={styles.menuItem}>
<div>
<div>View</div>
<div className={styles.menuItemSecondary}>Read, use</div>
<div>Use</div>
<div className={styles.menuItemSecondary}>
Can read and use this template to create workspaces.
</div>
</div>
</MenuItem>
<MenuItem key="admin" value="admin" className={styles.menuItem}>
<div>
<div>Admin</div>
<div className={styles.menuItemSecondary}>
Read, use, edit, push, and delete
Can modify all aspects of this template including permissions,
metadata, and template versions.
</div>
</div>
</MenuItem>
@@ -386,6 +389,8 @@ export const useStyles = makeStyles((theme) => {
lineHeight: "140%",
paddingTop: theme.spacing(1.5),
paddingBottom: theme.spacing(1.5),
whiteSpace: "normal",
inlineSize: "250px",
},
menuItemSecondary: {
+2 -2
View File
@@ -920,10 +920,10 @@ export const MockGroup: TypesGen.Group = {
export const MockTemplateACL: TypesGen.TemplateACL = {
group: [
{ ...everyOneGroup(MockOrganization.id), role: "view" },
{ ...everyOneGroup(MockOrganization.id), role: "use" },
{ ...MockGroup, role: "admin" },
],
users: [{ ...MockUser, role: "view" }],
users: [{ ...MockUser, role: "use" }],
}
export const MockTemplateACLEmpty: TypesGen.TemplateACL = {