From 0c30a114d1f0d34eb72660abdd99223dcc9e56d7 Mon Sep 17 00:00:00 2001 From: Bruno Quaresma Date: Fri, 24 Jan 2025 09:25:20 -0300 Subject: [PATCH] refactor: remove Docs from the navbar (#16251) Close #16247 --- .../modules/dashboard/Navbar/MobileMenu.stories.tsx | 1 - site/src/modules/dashboard/Navbar/MobileMenu.tsx | 8 -------- site/src/modules/dashboard/Navbar/Navbar.tsx | 1 - .../src/modules/dashboard/Navbar/NavbarView.test.tsx | 4 ---- site/src/modules/dashboard/Navbar/NavbarView.tsx | 12 ------------ 5 files changed, 26 deletions(-) diff --git a/site/src/modules/dashboard/Navbar/MobileMenu.stories.tsx b/site/src/modules/dashboard/Navbar/MobileMenu.stories.tsx index 19c66c14b3..6991a8af49 100644 --- a/site/src/modules/dashboard/Navbar/MobileMenu.stories.tsx +++ b/site/src/modules/dashboard/Navbar/MobileMenu.stories.tsx @@ -39,7 +39,6 @@ const meta: Meta = { }, user: MockUser, supportLinks: MockSupportLinks, - docsHref: "https://coder.com/docs", onSignOut: fn(), isDefaultOpen: true, canViewAuditLog: true, diff --git a/site/src/modules/dashboard/Navbar/MobileMenu.tsx b/site/src/modules/dashboard/Navbar/MobileMenu.tsx index d9662939a4..eb353d8d0b 100644 --- a/site/src/modules/dashboard/Navbar/MobileMenu.tsx +++ b/site/src/modules/dashboard/Navbar/MobileMenu.tsx @@ -45,7 +45,6 @@ type MobileMenuProps = MobileMenuPermissions & { proxyContextValue?: ProxyContextValue; user?: TypesGen.User; supportLinks?: readonly TypesGen.LinkConfig[]; - docsHref: string; onSignOut: () => void; isDefaultOpen?: boolean; // Useful for storybook }; @@ -55,7 +54,6 @@ export const MobileMenu: FC = ({ proxyContextValue, user, supportLinks, - docsHref, onSignOut, ...permissions }) => { @@ -90,12 +88,6 @@ export const MobileMenu: FC = ({ )} - - - Docs - - - { canViewHealth={canViewHealth} canViewAuditLog={canViewAuditLog} proxyContextValue={proxyContextValue} - docsHref={appearance.docs_url} /> ); }; diff --git a/site/src/modules/dashboard/Navbar/NavbarView.test.tsx b/site/src/modules/dashboard/Navbar/NavbarView.test.tsx index 7b51561dde..9d999d6fd0 100644 --- a/site/src/modules/dashboard/Navbar/NavbarView.test.tsx +++ b/site/src/modules/dashboard/Navbar/NavbarView.test.tsx @@ -25,7 +25,6 @@ describe("NavbarView", () => { it("workspaces nav link has the correct href", async () => { renderWithAuth( { it("templates nav link has the correct href", async () => { renderWithAuth( { it("audit nav link has the correct href", async () => { renderWithAuth( { it("deployment nav link has the correct href", async () => { renderWithAuth( void; @@ -33,7 +32,6 @@ const linkStyles = { export const NavbarView: FC = ({ user, logo_url, - docsHref, buildInfo, supportLinks, onSignOut, @@ -67,15 +65,6 @@ export const NavbarView: FC = ({ canViewHealth={canViewHealth} /> - - Docs - - {user && ( = ({ proxyContextValue={proxyContextValue} user={user} supportLinks={supportLinks} - docsHref={docsHref} onSignOut={onSignOut} canViewAuditLog={canViewAuditLog} canViewOrganizations={canViewOrganizations}