From 0880a4685b649e1148de703b269855ddcc4500ac Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Mon, 30 Mar 2026 17:28:51 +0100 Subject: [PATCH] ci: fix pnpm not found in check-docs job (#23807) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Enable corepack before the linkspector step so `pnpm` shim is in PATH - `action-linkspector@v1.4.1` internally calls `actions/setup-node@v5`, which now defaults `package-manager-cache: true` — it detects `pnpm-lock.yaml` and tries to resolve the `pnpm` binary, but it's not installed on the runner - Add TODO to remove the workaround when upstream is fixed Upstream: https://github.com/UmbrellaDocs/action-linkspector/issues/54 > 🤖 Cian asked a Coder Agent to make this PR and then reviewed the change. --- .github/workflows/weekly-docs.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/weekly-docs.yaml b/.github/workflows/weekly-docs.yaml index ab888e7e90..3feb658580 100644 --- a/.github/workflows/weekly-docs.yaml +++ b/.github/workflows/weekly-docs.yaml @@ -46,6 +46,12 @@ jobs: echo " replacement: \"https://github.com/coder/coder/tree/${HEAD_SHA}/\"" } >> .github/.linkspector.yml + # TODO: Remove this workaround once action-linkspector sets + # package-manager-cache: false in its internal setup-node step. + # See: https://github.com/UmbrellaDocs/action-linkspector/issues/54 + - name: Enable corepack + run: corepack enable pnpm + - name: Check Markdown links uses: umbrelladocs/action-linkspector@37c85bcde51b30bf929936502bac6bfb7e8f0a4d # v1.4.1 id: markdown-link-check