diff --git a/site/src/pages/TerminalPage/TerminalPage.test.tsx b/site/src/pages/TerminalPage/TerminalPage.test.tsx index 2156cec244..74f5caabc7 100644 --- a/site/src/pages/TerminalPage/TerminalPage.test.tsx +++ b/site/src/pages/TerminalPage/TerminalPage.test.tsx @@ -238,17 +238,15 @@ describe("TerminalPage", () => { expect(resizeReq.width).toBeGreaterThan(0); }); - it("removes command param on cancel", async () => { - createWorkspaceTerminalWebSocket(); + it("closes window on cancel", async () => { + const closeSpy = vi.spyOn(window, "close").mockImplementation(() => {}); renderTerminalRaw( `/${MockUserOwner.username}/${MockWorkspace.name}/terminal?command=echo+hello`, ); await userEvent.click( await screen.findByRole("button", { name: "Cancel" }), ); - await waitFor(() => - expect(screen.queryByRole("dialog")).not.toBeInTheDocument(), - ); + expect(closeSpy).toHaveBeenCalled(); }); it("skips confirmation dialog for trusted app commands", async () => { diff --git a/site/src/pages/TerminalPage/TerminalPage.tsx b/site/src/pages/TerminalPage/TerminalPage.tsx index 38a65a8d83..3e00fc802f 100644 --- a/site/src/pages/TerminalPage/TerminalPage.tsx +++ b/site/src/pages/TerminalPage/TerminalPage.tsx @@ -213,8 +213,7 @@ const TerminalPage: FC = () => { setCommandConfirmed(true); }} onDeny={() => { - searchParams.delete("command"); - navigate({ search: searchParams.toString() }, { replace: true }); + window.close(); }} /> )}