From 059546e92a5a441af78b06bd633290b5c218581a Mon Sep 17 00:00:00 2001 From: Ethan <39577870+ethanndickson@users.noreply.github.com> Date: Wed, 19 Aug 2026 17:21:44 +0800 Subject: [PATCH] ci: skip oversized flake-check selections (#28293) Skip the targeted Go flake check when a change selects more than 100 tests, and update `whichtests` to the version that supports this limit. Large selections usually come from broad or mechanical changes rather than a narrowly introduced flaky behavior. Repeating hundreds of tests substantially increases runtime and runner resource usage while providing less focused signal; regular CI still exercises the affected test suite across its normal jobs and repetitions. --- .github/workflows/flake-go.yaml | 1 + mise.lock | 2 +- mise.toml | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/flake-go.yaml b/.github/workflows/flake-go.yaml index 8a368111e5..41dc416ec0 100644 --- a/.github/workflows/flake-go.yaml +++ b/.github/workflows/flake-go.yaml @@ -59,6 +59,7 @@ jobs: --repo-root . \ --github-actions \ --coalesce \ + --max-selected-tests 100 \ --out-matrix "$RUNNER_TEMP/flake-matrix.json" - name: Set up Terraform diff --git a/mise.lock b/mise.lock index 1e12256c64..02442a453f 100644 --- a/mise.lock +++ b/mise.lock @@ -489,7 +489,7 @@ version = "337309bfb9524f38466a5090e310040fc7af0203" backend = "go:github.com/coder/sqlc/cmd/sqlc" [[tools."go:github.com/coder/whichtests"]] -version = "ec33bab1ec04cd86beb7a61a069db4463dba63f5" +version = "377b8dbf1cccae3b04b48bc8cfc2410813491414" backend = "go:github.com/coder/whichtests" [[tools."go:github.com/golang-migrate/migrate/v4/cmd/migrate"]] diff --git a/mise.toml b/mise.toml index 64a7ddb016..efac2ca4c1 100644 --- a/mise.toml +++ b/mise.toml @@ -21,7 +21,7 @@ protoc-gen-go = "1.30.0" # Go development tools. "go:github.com/coder/paralleltestctx/cmd/paralleltestctx" = "v0.0.2" -"go:github.com/coder/whichtests" = "ec33bab1ec04cd86beb7a61a069db4463dba63f5" +"go:github.com/coder/whichtests" = "377b8dbf1cccae3b04b48bc8cfc2410813491414" # Keep golangci-lint on the Go backend while pinned to v1. The upstream # precompiled v1 binary is built with an older Go toolchain and cannot lint # this module's Go version. Upgrading to v2 should let us use the native