fix: resolve missing users in <UserCombobox /> (#21822)

Closes #21044

This pull-request addresses an issue we were seeing where we would
attempt to filter the `<UserCombobox />` by the users username or email
not their username (which the rendered options would show).

To highlight this I created three different users. Each with a username
that did not contain their `email` or `name` and attempted to filter.
Attempting to search for `John` wouldn't actually show the user as his
username was `x`, and infact whereas a subset of users might be returned
from the backend for having `john` in the `email` it would've been
filtered by the frontend for not being in the `name` field.

| Name | Username |
| --- | --- |
| `Jake` | `z` |  
| `Jeff` | `y` |
| `John` | `x` |

| Previously | Now |
| --- | --- |
| <img width="560" height="547" alt="OLD_USER_COMBOBOX"
src="https://github.com/user-attachments/assets/a0567264-0034-42ac-aba0-95b05c4f92dd"
/> | <img width="580" height="548" alt="NEW_USER_COMBOBOX"
src="https://github.com/user-attachments/assets/1aa0c942-d340-4b1c-8dde-b97879525bfb"
/> |
This commit is contained in:
Jake Howell
2026-02-03 00:13:41 +11:00
committed by GitHub
parent 3e369c0b04
commit 052bd114a4
9 changed files with 193 additions and 23 deletions
+4
View File
@@ -26,6 +26,7 @@ const (
type UsersRequest struct {
Search string `json:"search,omitempty" typescript:"-"`
Name string `json:"name,omitempty" typescript:"-"`
// Filter users by status.
Status UserStatus `json:"status,omitempty" typescript:"-"`
// Filter users that have the given role.
@@ -847,6 +848,9 @@ func (c *Client) Users(ctx context.Context, req UsersRequest) (GetUsersResponse,
if req.Search != "" {
params = append(params, req.Search)
}
if req.Name != "" {
params = append(params, "name:"+req.Name)
}
if req.Status != "" {
params = append(params, "status:"+string(req.Status))
}