From 04032f2a97fe075b121add0ed995ec3bbb23be7d Mon Sep 17 00:00:00 2001 From: Ethan <39577870+ethanndickson@users.noreply.github.com> Date: Thu, 12 Dec 2024 17:22:51 +1100 Subject: [PATCH] ci: only build dylib on PRs with Go changes (#15839) For some reason we were building the dylib on any code changes, now it's just Go (and CI) changes - using the same condition that `go-test` uses. `if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'` The main check ensures that it's always run before `build` is run. --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index af2a7bb1bd..d0cc85b705 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -895,7 +895,7 @@ jobs: needs: changes # We always build the dylibs on Go changes to verify we're not merging unbuildable code, # but they need only be signed and uploaded on coder/coder main. - if: needs.changes.outputs.docs-only == 'false' || github.ref == 'refs/heads/main' + if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' runs-on: ${{ github.repository_owner == 'coder' && 'depot-macos-latest' || 'macos-latest' }} steps: - name: Harden Runner