chore: return 404, not 400 if missing or authz deny (#22069)

enterprise/cli/organizationmembers_test.go

@@ -64,7 +64,7 @@ func TestRemoveOrganizationMembers(t *testing.T) {
 		buf := new(bytes.Buffer)
 		inv.Stdout = buf
 		err := inv.WithContext(ctx).Run()
-		require.ErrorContains(t, err, "must be an existing uuid or username")
+		require.ErrorContains(t, err, "Resource not found or you do not have access to this resource")
 	})
 }
 

enterprise/coderd/users_test.go

@@ -356,7 +356,7 @@ func TestGrantSiteRoles(t *testing.T) {
 			AssignToUser: uuid.NewString(),
 			Roles:        []string{codersdk.RoleOwner},
 			Error:        true,
-			StatusCode:   http.StatusBadRequest,
+			StatusCode:   http.StatusNotFound,
 		},
 		{
 			Name:         "MemberCannotUpdateRoles",
@@ -364,7 +364,7 @@ func TestGrantSiteRoles(t *testing.T) {
 			AssignToUser: first.UserID.String(),
 			Roles:        []string{},
 			Error:        true,
-			StatusCode:   http.StatusBadRequest,
+			StatusCode:   http.StatusNotFound,
 		},
 		{
 			// Cannot update your own roles

enterprise/members_test.go

@@ -152,7 +152,7 @@ func TestEnterpriseMembers(t *testing.T) {
 		require.Error(t, err)
 		var apiErr *codersdk.Error
 		require.ErrorAs(t, err, &apiErr)
-		require.Contains(t, apiErr.Message, "must be an existing")
+		require.Contains(t, apiErr.Message, "Resource not found or you do not have access to this resource")
 	})
 
 	// Calling it from a user without the org access.