From 0d21d7f41a7791a176848b5581075593f3a9d898 Mon Sep 17 00:00:00 2001
From: Yousong Zhou <zhouyousong@yunionyun.com>
Date: Mon, 30 Dec 2019 17:55:53 +0800
Subject: [PATCH] networks: make ifname hint also valid qemu identifier

---
 pkg/compute/models/networks.go | 43 +++++++++++++++++++++++-----------
 1 file changed, 29 insertions(+), 14 deletions(-)

diff --git a/pkg/compute/models/networks.go b/pkg/compute/models/networks.go
index 3b6610a670..bd37d5659e 100644
--- a/pkg/compute/models/networks.go
+++ b/pkg/compute/models/networks.go
@@ -1127,33 +1127,48 @@ func isValidMaskLen(maskLen int64) bool {
 }
 
 func (manager *SNetworkManager) newIfnameHint(hint string) (string, error) {
-	r := ""
-	// sanitize hint
-	for _, c := range hint {
-		if (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') || (c >= '0' && c <= '9') || c == '-' || c == '_' {
-			r += string(c)
-		}
+	isa := func(c byte) bool {
+		return (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z')
 	}
-	newHint := func() (string, error) {
+	isn := func(c byte) bool {
+		return (c >= '0' && c <= '9')
+	}
+	sani := func(r string) string {
+		if r != "" && !isa(r[0]) {
+			return "a" + r
+		}
+		return r
+	}
+	newHint := func(base string) (string, error) {
+		if len(base) > 8 {
+			base = base[:8]
+		}
 		for i := 0; i < 3; i++ {
-			r := rand.String(7)
+			r := base + rand.String(7)
 			cnt, err := manager.Query().Equals("ifname_hint", r).CountWithError()
 			if err == nil && cnt == 0 {
-				return r, nil
+				return sani(r), nil
 			}
 		}
 		return "", fmt.Errorf("failed finding ifname hint after 3 tries")
 	}
-	if len(r) < 3 {
-		return newHint()
+
+	r := ""
+	for i := range hint {
+		c := hint[i]
+		if isa(c) || isn(c) || c == '_' {
+			r += string(c)
+		}
 	}
-	if len(r) > 9 {
-		r = r[:9]
+	r = sani(r)
+
+	if len(r) < 3 {
+		return newHint(r)
 	}
 	if cnt, err := manager.Query().Equals("ifname_hint", r).CountWithError(); err != nil {
 		return "", err
 	} else if cnt > 0 {
-		r, err := newHint()
+		r, err := newHint(r)
 		return r, err
 	}
 	return r, nil