From 65096570a53fdbbed4f8de7ceb5fca73c9a74293 Mon Sep 17 00:00:00 2001
From: Qiu Jian <qiujian@yunionyun.com>
Date: Sat, 23 Jan 2021 23:47:07 +0800
Subject: [PATCH] fix(keystone): user create without password can login with
 any password

---
 pkg/keystone/models/users.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pkg/keystone/models/users.go b/pkg/keystone/models/users.go
index c511056658..32f1a33ae8 100644
--- a/pkg/keystone/models/users.go
+++ b/pkg/keystone/models/users.go
@@ -299,10 +299,10 @@ func VerifyPassword(user *api.SUserExtended, passwd string) error {
 func localUserVerifyPassword(user *api.SUserExtended, passwd string) error {
 	passes, err := PasswordManager.fetchByLocaluserId(user.LocalId)
 	if err != nil {
-		return err
+		return errors.Wrap(err, "fetchPassword")
 	}
 	if len(passes) == 0 {
-		return nil
+		return errors.Error("no valid password")
 	}
 	// password expiration check skip system account
 	if passes[0].IsExpired() && !user.IsSystemAccount {