From f517795c85cab0db981c348b02cc1dbf94a0fac2 Mon Sep 17 00:00:00 2001 From: zhaoxiangchun <1422928955@qq.com> Date: Wed, 8 Sep 2021 18:01:12 +0800 Subject: [PATCH] fix(monitor): add record shield details param --- pkg/apis/monitor/monitor_resource_alert.go | 2 ++ pkg/monitor/models/monitor_resource_alert.go | 3 +++ pkg/monitor/models/recordshield.go | 4 +--- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/pkg/apis/monitor/monitor_resource_alert.go b/pkg/apis/monitor/monitor_resource_alert.go index 99fe2fe3a0..56ed2f430c 100644 --- a/pkg/apis/monitor/monitor_resource_alert.go +++ b/pkg/apis/monitor/monitor_resource_alert.go @@ -45,9 +45,11 @@ type MonitorResourceJointCreateInput struct { type MonitorResourceJointDetails struct { ResName string `json:"res_name"` + ResId string `json:"res_id"` ResType string `json:"res_type"` AlertName string `json:"alert_name"` AlertRule jsonutils.JSONObject `json:"alert_rule"` Level string `json:"level"` SendState string `json:"send_state"` + State string `json:"state"` } diff --git a/pkg/monitor/models/monitor_resource_alert.go b/pkg/monitor/models/monitor_resource_alert.go index ce50b3933e..c715752051 100644 --- a/pkg/monitor/models/monitor_resource_alert.go +++ b/pkg/monitor/models/monitor_resource_alert.go @@ -204,6 +204,8 @@ func (obj *SMonitorResourceAlert) getMoreDetails(detail monitor.MonitorResourceJ } detail.ResType = resources[0].ResType detail.ResName = resources[0].Name + detail.ResId = resources[0].ResId + if len(obj.AlertRecordId) != 0 { record, err := AlertRecordManager.GetAlertRecord(obj.AlertRecordId) if err != nil { @@ -213,6 +215,7 @@ func (obj *SMonitorResourceAlert) getMoreDetails(detail monitor.MonitorResourceJ detail.Level = record.Level detail.AlertRule = record.AlertRule detail.SendState = record.SendState + detail.State = record.State } return detail } diff --git a/pkg/monitor/models/recordshield.go b/pkg/monitor/models/recordshield.go index 174dd61fc8..4b9a5129f1 100644 --- a/pkg/monitor/models/recordshield.go +++ b/pkg/monitor/models/recordshield.go @@ -226,9 +226,7 @@ func (man *SAlertRecordShieldManager) ValidateCreateData(ctx context.Context, us if data.EndTime.Before(data.StartTime) { return data, httperrors.NewInputParameterError("end_time is before start_time") } - if data.EndTime.Before(time.Now()) { - return data, httperrors.NewInputParameterError("end_time is before now") - } + hint := fmt.Sprintf("%s-%s", alert.Name, data.ResName) name, err := db.GenerateName(ctx, man, ownerId, hint) if err != nil {