diff --git a/pkg/apigateway/options/options.go b/pkg/apigateway/options/options.go index 5a2df99e14..a0f16611f1 100644 --- a/pkg/apigateway/options/options.go +++ b/pkg/apigateway/options/options.go @@ -40,9 +40,10 @@ func OnOptionsChange(oldO, newO interface{}) bool { oldOpts := oldO.(*GatewayOptions) newOpts := newO.(*GatewayOptions) + changed := false if common_options.OnCommonOptionsChange(&oldOpts.CommonOptions, &newOpts.CommonOptions) { - return true + changed = true } - return false + return changed } diff --git a/pkg/cloudcommon/consts/consts.go b/pkg/cloudcommon/consts/consts.go index 0a2396e460..45b9c16b9d 100644 --- a/pkg/cloudcommon/consts/consts.go +++ b/pkg/cloudcommon/consts/consts.go @@ -16,6 +16,8 @@ package consts import ( "time" + + "yunion.io/x/log" ) var ( @@ -58,6 +60,7 @@ func GetTenantCacheExpireSeconds() time.Duration { } func SetNonDefaultDomainProjects(val bool) { + log.Infof("set non_default_domain_projects to %v", val) nonDefaultDomainProjects = val } diff --git a/pkg/cloudcommon/options/changes.go b/pkg/cloudcommon/options/changes.go index 6f1bdf94e4..35476609b6 100644 --- a/pkg/cloudcommon/options/changes.go +++ b/pkg/cloudcommon/options/changes.go @@ -22,27 +22,31 @@ func OnBaseOptionsChange(oOpts, nOpts interface{}) bool { oldOpts := oOpts.(*BaseOptions) newOpts := nOpts.(*BaseOptions) + changed := false if oldOpts.RequestWorkerCount != newOpts.RequestWorkerCount { - return true + changed = true } if oldOpts.TimeZone != newOpts.TimeZone { - return true + changed = true } if oldOpts.EnableRbac != newOpts.EnableRbac { - return true + changed = true } if oldOpts.NonDefaultDomainProjects != newOpts.NonDefaultDomainProjects { consts.SetNonDefaultDomainProjects(newOpts.NonDefaultDomainProjects) + changed = true } - return false + return changed } func OnCommonOptionsChange(oOpts, nOpts interface{}) bool { oldOpts := oOpts.(*CommonOptions) newOpts := nOpts.(*CommonOptions) + changed := false if OnBaseOptionsChange(&oldOpts.BaseOptions, &newOpts.BaseOptions) { - return true + changed = true } - return false + + return changed } diff --git a/pkg/compute/options/options.go b/pkg/compute/options/options.go index 130cc20b95..26c0ac9b0c 100644 --- a/pkg/compute/options/options.go +++ b/pkg/compute/options/options.go @@ -141,8 +141,9 @@ func OnOptionsChange(oldO, newO interface{}) bool { oldOpts := oldO.(*ComputeOptions) newOpts := newO.(*ComputeOptions) + changed := false if common_options.OnCommonOptionsChange(&oldOpts.CommonOptions, &newOpts.CommonOptions) { - return true + changed = true } - return false + return changed } diff --git a/pkg/image/options/options.go b/pkg/image/options/options.go index 0e022a5b07..743f5a7e6f 100644 --- a/pkg/image/options/options.go +++ b/pkg/image/options/options.go @@ -51,9 +51,10 @@ func OnOptionsChange(oldO, newO interface{}) bool { oldOpts := oldO.(*SImageOptions) newOpts := newO.(*SImageOptions) + changed := false if common_options.OnCommonOptionsChange(&oldOpts.CommonOptions, &newOpts.CommonOptions) { - return true + changed = true } - return false + return changed } diff --git a/pkg/keystone/options/options.go b/pkg/keystone/options/options.go index 45ba8b9719..5a4bbb8b0a 100644 --- a/pkg/keystone/options/options.go +++ b/pkg/keystone/options/options.go @@ -53,9 +53,10 @@ func OnOptionsChange(oldOptions, newOptions interface{}) bool { oldOpts := oldOptions.(*SKeystoneOptions) newOpts := newOptions.(*SKeystoneOptions) + changed := false if options.OnBaseOptionsChange(&oldOpts.BaseOptions, &newOpts.BaseOptions) { - return true + changed = true } - return false + return changed } diff --git a/pkg/notify/options/options.go b/pkg/notify/options/options.go index 22f24aaed8..ed334c7037 100644 --- a/pkg/notify/options/options.go +++ b/pkg/notify/options/options.go @@ -26,8 +26,8 @@ type NotifyOption struct { SocketFileDir string `help:"Socket file directory" default:"/etc/yunion/notify"` UpdateInterval int `help:"Update send services interval(unit:min)" default:"30"` VerifyEmailUrl string `help:"url of verify email"` - ReSendScope int `help:"Resend all messages that have not been sent successfully within ReSendScope -seconds" default:"30"` + + ReSendScope int `help:"Resend all messages that have not been sent successfully within ReSendScope seconds" default:"30"` InitNotificationScope int `help:"initialize data of notification with in InitNotificationScope hours" default:"100"` }