From d45d48806b1d096eaab6ee77c1c601645f7608c8 Mon Sep 17 00:00:00 2001
From: Qu Xuan <quxuan@yunionyun.com>
Date: Tue, 29 Sep 2020 11:11:19 +0800
Subject: [PATCH] fix: allow domain admin view shared dns zone records

---
 pkg/compute/models/dns_recordsets.go |  8 ++++++++
 pkg/compute/policy/defaults.go       | 12 ++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/pkg/compute/models/dns_recordsets.go b/pkg/compute/models/dns_recordsets.go
index 4eb90e6e88..db0f9697c0 100644
--- a/pkg/compute/models/dns_recordsets.go
+++ b/pkg/compute/models/dns_recordsets.go
@@ -387,6 +387,14 @@ func (manager *SDnsRecordSetManager) ResourceScope() rbacutils.TRbacScope {
 	return rbacutils.ScopeDomain
 }
 
+func (self *SDnsRecordSet) IsSharable(reqUsrId mcclient.IIdentityProvider) bool {
+	dnsZone, err := self.GetDnsZone()
+	if err != nil {
+		return false
+	}
+	return dnsZone.IsSharable(reqUsrId)
+}
+
 func (self *SDnsRecordSet) GetOwnerId() mcclient.IIdentityProvider {
 	dnsZone, err := self.GetDnsZone()
 	if err != nil {
diff --git a/pkg/compute/policy/defaults.go b/pkg/compute/policy/defaults.go
index f00d3682d1..0074e181dc 100644
--- a/pkg/compute/policy/defaults.go
+++ b/pkg/compute/policy/defaults.go
@@ -131,6 +131,18 @@ var (
 					Action:   PolicyActionList,
 					Result:   rbacutils.Allow,
 				},
+				{
+					Service:  api.SERVICE_TYPE,
+					Resource: "dns_recordsets",
+					Action:   PolicyActionList,
+					Result:   rbacutils.Allow,
+				},
+				{
+					Service:  api.SERVICE_TYPE,
+					Resource: "dns_recodsets",
+					Action:   PolicyActionGet,
+					Result:   rbacutils.Allow,
+				},
 			},
 		},
 		{