From 4c6682617cfcd2c8a6503b419c48c765496a31ec Mon Sep 17 00:00:00 2001 From: rainzm Date: Tue, 9 Jun 2020 19:45:46 +0800 Subject: [PATCH] fix: Hanle the error of vdisk.GetIStorage in syncCloudDisk --- pkg/compute/models/disks.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/compute/models/disks.go b/pkg/compute/models/disks.go index e3d14bb0fc..e3d81a71e5 100644 --- a/pkg/compute/models/disks.go +++ b/pkg/compute/models/disks.go @@ -1218,7 +1218,10 @@ func (manager *SDiskManager) syncCloudDisk(ctx context.Context, userCred mcclien diskObj, err := db.FetchByExternalId(manager, vdisk.GetGlobalId()) if err != nil { if err == sql.ErrNoRows { - vstorage, _ := vdisk.GetIStorage() + vstorage, err := vdisk.GetIStorage() + if err != nil { + return nil, errors.Wrapf(err, "unable to GetIStorage of vdisk %q", vdisk.GetName()) + } storageObj, err := db.FetchByExternalId(StorageManager, vstorage.GetGlobalId()) if err != nil {