fix: use json to store task error message (#7351)

Co-authored-by: Qiu Jian <qiujian@yunionyun.com>
This commit is contained in:
Jian Qiu
2020-07-30 10:34:32 +08:00
committed by GitHub
co-authored by Qiu Jian
parent 3df146ff6f
commit ba292dfedc
216 changed files with 1421 additions and 1315 deletions
@@ -30,7 +30,6 @@ package tasks
import (
"context"
"fmt"
"yunion.io/x/jsonutils"
@@ -52,7 +51,7 @@ func (self *TemplateBindingServers) OnInit(ctx context.Context, obj db.IStandalo
template := obj.(*models.SDevtoolTemplate)
_, err := template.Binding(ctx, self.UserCred, nil, self.Params)
if err != nil {
self.SetStageFailed(ctx, fmt.Sprintf("TemplateUpdate failed %s", err))
self.SetStageFailed(ctx, jsonutils.Marshal(err))
} else {
self.SetStageComplete(ctx, nil)
}
@@ -52,7 +52,7 @@ func (self *TemplateUnbindingServers) OnInit(ctx context.Context, obj db.IStanda
template := obj.(*models.SDevtoolTemplate)
_, err := template.Unbinding(ctx, self.UserCred, nil, self.Params)
if err != nil {
self.SetStageFailed(ctx, fmt.Sprintf("TemplateUnBindingServers failed %s", err))
self.SetStageFailed(ctx, jsonutils.NewString(fmt.Sprintf("TemplateUnBindingServers failed %s", err)))
} else {
self.SetStageComplete(ctx, nil)
}
+1 -1
View File
@@ -52,7 +52,7 @@ func (self *TemplateUpdate) OnInit(ctx context.Context, obj db.IStandaloneModel,
template := obj.(*models.SDevtoolTemplate)
_, err := template.TaskUpdate(ctx, self.UserCred, nil, self.Params)
if err != nil {
self.SetStageFailed(ctx, fmt.Sprintf("TemplateUpdate failed %s", err))
self.SetStageFailed(ctx, jsonutils.NewString(fmt.Sprintf("TemplateUpdate failed %s", err)))
} else {
self.SetStageComplete(ctx, nil)
}