From b242af75f40c7383b1031e505decc016a85a6449 Mon Sep 17 00:00:00 2001 From: Yousong Zhou Date: Fri, 7 May 2021 18:55:54 +0800 Subject: [PATCH] guests: sshable: log error should unmarshal fail --- pkg/compute/models/guest_sshable.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/compute/models/guest_sshable.go b/pkg/compute/models/guest_sshable.go index a2cd23d04b..987ab1ed6d 100644 --- a/pkg/compute/models/guest_sshable.go +++ b/pkg/compute/models/guest_sshable.go @@ -207,10 +207,11 @@ func (guest *SGuest) sshableTryEach( res, err := cloudproxy_module.Forwards.PerformClassAction(sess, "create-from-server", fwdCreateParams) if err == nil { var fwd cloudproxy_api.ForwardDetails - if err := res.Unmarshal(&fwd); err == nil { - if ok := guest.sshableTryForward(ctx, tryData, &fwd); ok { - return nil - } + if err := res.Unmarshal(&fwd); err != nil { + log.Errorf("unmarshal fwd details: %q", res.String()) + } + if ok := guest.sshableTryForward(ctx, tryData, &fwd); ok { + return nil } } else { var reason string