From 89f745ae0bb5c7763577ba8d8ffac17520d6d1ae Mon Sep 17 00:00:00 2001
From: wanyaoqi <d3lx.yq@gmail.com>
Date: Wed, 1 Mar 2023 22:57:53 +0800
Subject: [PATCH] fix(host): dest guest load pci addresses on live migrate

Signed-off-by: wanyaoqi <d3lx.yq@gmail.com>
---
 pkg/compute/models/guest_actions.go |  9 ++++++-
 pkg/hostman/guestman/qemu-kvm.go    | 38 ++++++++++++++++++++++-------
 2 files changed, 37 insertions(+), 10 deletions(-)

diff --git a/pkg/compute/models/guest_actions.go b/pkg/compute/models/guest_actions.go
index d8166b2d3f..2dae92f675 100644
--- a/pkg/compute/models/guest_actions.go
+++ b/pkg/compute/models/guest_actions.go
@@ -2904,9 +2904,16 @@ func (self *SGuest) SetBackupGuestStatus(userCred mcclient.TokenCredential, stat
 }
 
 func (self *SGuest) PerformStatus(ctx context.Context, userCred mcclient.TokenCredential, query jsonutils.JSONObject, input apis.PerformStatusInput) (jsonutils.JSONObject, error) {
-	if input.HostId != "" && self.BackupHostId != "" && input.HostId == self.BackupHostId { // perform status called from slave guest
+	if input.HostId != "" && self.BackupHostId != "" && input.HostId == self.BackupHostId {
+		// perform status called from slave guest
 		return nil, self.SetBackupGuestStatus(userCred, input.Status, input.Reason)
 	}
+
+	if input.HostId != "" && input.HostId != self.HostId {
+		// perform status called from volatile host, eg: migrate dest host
+		return nil, nil
+	}
+
 	if input.PowerStates != "" {
 		if err := self.SetPowerStates(input.PowerStates); err != nil {
 			return nil, errors.Wrap(err, "set power states")
diff --git a/pkg/hostman/guestman/qemu-kvm.go b/pkg/hostman/guestman/qemu-kvm.go
index 89a92cc19c..d11bf24c1f 100644
--- a/pkg/hostman/guestman/qemu-kvm.go
+++ b/pkg/hostman/guestman/qemu-kvm.go
@@ -163,18 +163,38 @@ func (s *SKVMGuestInstance) initLiveDescFromSourceGuest(srcDesc *desc.SGuestDesc
 	srcDesc.SGuestRegionDesc = s.SourceDesc.SGuestRegionDesc
 	srcDesc.SGuestControlDesc = s.SourceDesc.SGuestControlDesc
 	srcDesc.SGuestMetaDesc = s.SourceDesc.SGuestMetaDesc
-	for i := 0; i < len(s.SourceDesc.Cdroms); i++ {
+	for i := 0; i < len(srcDesc.Cdroms); i++ {
+		if i == len(s.SourceDesc.Cdroms) {
+			break
+		}
 		srcDesc.Cdroms[i].Path = s.SourceDesc.Cdroms[i].Path
 	}
-	for i := 0; i < len(s.SourceDesc.Disks); i++ {
-		srcDesc.Disks[i].GuestdiskJsonDesc = s.SourceDesc.Disks[i].GuestdiskJsonDesc
-	}
-	for i := 0; i < len(s.SourceDesc.Nics); i++ {
-		if err := s.generateNicScripts(s.SourceDesc.Nics[i]); err != nil {
-			return errors.Wrapf(err, "generateNicScripts for nic: %v", s.SourceDesc.Nics[i])
+	for i := 0; i < len(srcDesc.Disks); i++ {
+		for j := 0; j < len(s.SourceDesc.Disks); j++ {
+			if srcDesc.Disks[i].Index == s.SourceDesc.Disks[j].Index {
+				srcDesc.Disks[i].GuestdiskJsonDesc = s.SourceDesc.Disks[j].GuestdiskJsonDesc
+			}
 		}
-		srcDesc.Nics[i].UpscriptPath = s.getNicUpScriptPath(s.SourceDesc.Nics[i])
-		srcDesc.Nics[i].DownscriptPath = s.getNicDownScriptPath(s.SourceDesc.Nics[i])
+	}
+	for i := 0; i < len(srcDesc.Nics); i++ {
+		for j := 0; j < len(s.SourceDesc.Nics); j++ {
+			if srcDesc.Nics[i].Index == s.SourceDesc.Nics[j].Index {
+				srcDesc.Nics[i].GuestnetworkJsonDesc = s.SourceDesc.Nics[j].GuestnetworkJsonDesc
+				break
+			}
+		}
+
+		if err := s.generateNicScripts(srcDesc.Nics[i]); err != nil {
+			return errors.Wrapf(err, "generateNicScripts for nic: %v", srcDesc.Nics[i])
+		}
+		srcDesc.Nics[i].UpscriptPath = s.getNicUpScriptPath(srcDesc.Nics[i])
+		srcDesc.Nics[i].DownscriptPath = s.getNicDownScriptPath(srcDesc.Nics[i])
+	}
+
+	s.Desc = srcDesc
+	err := s.loadGuestPciAddresses()
+	if err != nil {
+		return errors.Wrap(err, "initLiveDescFromSourceGuest")
 	}
 	return s.SaveLiveDesc(srcDesc)
 }