From 5ebfcce724d526bbaa890d00ce69919c032e5445 Mon Sep 17 00:00:00 2001
From: Zexi Li <zexi.li@icloud.com>
Date: Wed, 1 Mar 2023 17:19:15 +0800
Subject: [PATCH] fix(monitor): rewrite slimit and soffset logic

---
 pkg/monitor/models/unifiedmonitor.go | 40 ++++++++++++++++++++++------
 1 file changed, 32 insertions(+), 8 deletions(-)

diff --git a/pkg/monitor/models/unifiedmonitor.go b/pkg/monitor/models/unifiedmonitor.go
index 5bcd4a7649..bc89f91a96 100644
--- a/pkg/monitor/models/unifiedmonitor.go
+++ b/pkg/monitor/models/unifiedmonitor.go
@@ -17,6 +17,7 @@ package models
 import (
 	"context"
 	"fmt"
+	"strconv"
 	"strings"
 	"time"
 
@@ -228,8 +229,28 @@ func (self *SUnifiedMonitorManager) PerformQuery(ctx context.Context, userCred m
 	}
 
 	if len(inputQuery.Soffset) != 0 && len(inputQuery.Slimit) != 0 {
-		seriesTotal := self.fillSearchSeriesTotalQuery(userCred, *inputQuery.MetricQuery[0])
-		rtn.SeriesTotal = seriesTotal
+		// seriesTotal := self.fillSearchSeriesTotalQuery(userCred, *inputQuery.MetricQuery[0])
+		// do offset and limit
+		total := rtn.SeriesTotal
+		offset, err := strconv.Atoi(inputQuery.Soffset)
+		if err != nil {
+			return nil, httperrors.NewInputParameterError("soffset %q is not integer", inputQuery.Soffset)
+		}
+		limit, err := strconv.Atoi(inputQuery.Slimit)
+		if err != nil {
+			return nil, httperrors.NewInputParameterError("slimit %q is not integer", inputQuery.Slimit)
+		}
+		start := offset
+		end := start + limit
+		if end > int(total) {
+			end = int(total)
+		}
+		ss := rtn.Series
+		if start >= end {
+			rtn.Series = nil
+		} else {
+			rtn.Series = ss[start:end]
+		}
 	}
 
 	setSerieRowName(&rtn.Series, groupByTag)
@@ -302,6 +323,7 @@ func doQuery(userCred mcclient.TokenCredential, query monitor.MetricInputQuery)
 	if !query.ShowMeta {
 		metrics.Metas = nil
 	}
+	metrics.SeriesTotal = int64(len(metrics.Series))
 	return metrics, nil
 }
 
@@ -343,12 +365,14 @@ func setDefaultValue(query *monitor.AlertQuery, inputQuery *monitor.MetricInputQ
 				Params: []string{"none"},
 			})
 	}
-	if len(inputQuery.Slimit) != 0 && len(inputQuery.Soffset) != 0 {
-		query.Model.GroupBy = append(query.Model.GroupBy,
-			monitor.MetricQueryPart{Type: "slimit", Params: []string{inputQuery.Slimit}},
-			monitor.MetricQueryPart{Type: "soffset", Params: []string{inputQuery.Soffset}},
-		)
-	}
+
+	// HACK: not set slimit and soffset, getting all series then do offset and limit
+	// if len(inputQuery.Slimit) != 0 && len(inputQuery.Soffset) != 0 {
+	// 	query.Model.GroupBy = append(query.Model.GroupBy,
+	// 		monitor.MetricQueryPart{Type: "slimit", Params: []string{inputQuery.Slimit}},
+	// 		monitor.MetricQueryPart{Type: "soffset", Params: []string{inputQuery.Soffset}},
+	// 	)
+	// }
 
 	if query.Model.Database == "" {
 		database := ""