diff --git a/pkg/proxy/http.go b/pkg/proxy/http.go index a554480dc0..87318cecca 100644 --- a/pkg/proxy/http.go +++ b/pkg/proxy/http.go @@ -3,7 +3,6 @@ package proxy import ( "context" "crypto/tls" - "fmt" "net/http" "net/http/httputil" "net/url" @@ -44,7 +43,7 @@ func (p *SReverseProxy) ServeHTTP(ctx context.Context, w http.ResponseWriter, r } remoteUrl, err := url.Parse(endpoint) if err != nil { - httperrors.InternalServerError(w, fmt.Sprintf("Parse remote url %q: %v", endpoint, err)) + httperrors.InternalServerError(w, "failed parsing url %q: %v", endpoint, err) return } log.Debugf("Forwarding to servie: %q, url: %q", p.serviceName, remoteUrl.String()) diff --git a/pkg/webconsole/server/server.go b/pkg/webconsole/server/server.go index ddb94f41a4..5b0dd2fc0a 100644 --- a/pkg/webconsole/server/server.go +++ b/pkg/webconsole/server/server.go @@ -1,7 +1,6 @@ package server import ( - "fmt" "net/http" "yunion.io/x/jsonutils" @@ -28,13 +27,12 @@ func (s *ConnectionServer) ServeHTTP(w http.ResponseWriter, req *http.Request) { log.Debugf("[connection] Get query: %v", query) accessToken, _ := query.GetString("access_token") if accessToken == "" { - httperrors.BadRequestError(w, fmt.Sprintf("Empty access_token")) + httperrors.BadRequestError(w, "Empty access_token") return } sessionObj, ok := session.Manager.Get(accessToken) if !ok { - log.Warningf("Not found session by token: %q", accessToken) - httperrors.NotFoundError(w, fmt.Sprintf("Not found session")) + httperrors.NotFoundError(w, "session not found") return } var srv http.Handler @@ -45,7 +43,7 @@ func (s *ConnectionServer) ServeHTTP(w http.ResponseWriter, req *http.Request) { srv, err = NewTTYServer(sessionObj) } if err != nil { - httperrors.GeneralServerError(w, fmt.Errorf("New server error: %v", err)) + httperrors.GeneralServerError(w, "New server error: %v", err) return } srv.ServeHTTP(w, req)