From 5c9be39f52c552e49963e95c1d2cf2eb321d934a Mon Sep 17 00:00:00 2001 From: Qiu Jian Date: Tue, 12 Feb 2019 17:08:23 +0800 Subject: [PATCH] log doCreateItem exceptions --- pkg/cloudcommon/db/db_dispatcher.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/cloudcommon/db/db_dispatcher.go b/pkg/cloudcommon/db/db_dispatcher.go index 0ce75deef8..2468727293 100644 --- a/pkg/cloudcommon/db/db_dispatcher.go +++ b/pkg/cloudcommon/db/db_dispatcher.go @@ -816,7 +816,11 @@ func FetchModelObjects(modelManager IModelManager, query *sqlchemy.SQuery, targe } func doCreateItem(manager IModelManager, ctx context.Context, userCred mcclient.TokenCredential, ownerProjId string, query jsonutils.JSONObject, data jsonutils.JSONObject) (IModel, error) { - dataDict := data.(*jsonutils.JSONDict) + dataDict, ok := data.(*jsonutils.JSONDict) + if !ok { + log.Errorf("doCreateItem: fail to decode json data %s", data) + return nil, fmt.Errorf("fail to decode json data %s", data) + } var err error generateName, _ := dataDict.GetString("generate_name")