From 43f4800cb80ff4ad44ac29e279442560b1d65b89 Mon Sep 17 00:00:00 2001 From: Zexi Li Date: Fri, 21 Jan 2022 11:40:25 +0800 Subject: [PATCH] fix(hostman): cmdline option range panic --- pkg/util/qemutils/cmdline.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/util/qemutils/cmdline.go b/pkg/util/qemutils/cmdline.go index c66095535c..7ed5317d34 100644 --- a/pkg/util/qemutils/cmdline.go +++ b/pkg/util/qemutils/cmdline.go @@ -66,12 +66,14 @@ func (o Option) ToString() string { type OptionFilter func(Option) bool func (cl *Cmdline) FilterOption(filter OptionFilter) { - for i, op := range cl.options { + opts := make([]Option, 0) + for _, op := range cl.options { if filter(op) { - // remove this option - cl.options = append(cl.options[:i], cl.options[i+1:]...) + continue } + opts = append(opts, op) } + cl.options = opts } func (cl *Cmdline) AddOption(opts ...Option) *Cmdline {