From 3ad40222c25ace3d5f0a192cada83a2207b61b55 Mon Sep 17 00:00:00 2001 From: Zexi Li Date: Fri, 18 Sep 2020 10:31:26 +0800 Subject: [PATCH] region: fix network schedtag not cleanup when network deleted --- pkg/compute/models/networks.go | 1 + pkg/compute/models/schedtags.go | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/compute/models/networks.go b/pkg/compute/models/networks.go index 74b1259171..7255b947ef 100644 --- a/pkg/compute/models/networks.go +++ b/pkg/compute/models/networks.go @@ -1691,6 +1691,7 @@ func (self *SNetwork) CustomizeDelete(ctx context.Context, userCred mcclient.Tok } func (self *SNetwork) RealDelete(ctx context.Context, userCred mcclient.TokenCredential) error { + DeleteResourceJointSchedtags(self, ctx, userCred) db.OpsLog.LogEvent(self, db.ACT_DELOCATE, self.GetShortDesc(ctx), userCred) self.SetStatus(userCred, api.NETWORK_STATUS_DELETED, "real delete") self.ClearSchedDescCache() diff --git a/pkg/compute/models/schedtags.go b/pkg/compute/models/schedtags.go index d6c85d4baa..99ebc99934 100644 --- a/pkg/compute/models/schedtags.go +++ b/pkg/compute/models/schedtags.go @@ -369,7 +369,7 @@ func (self *SSchedtag) GetObjectQuery() *sqlchemy.SQuery { q := objs.Query() q = q.Join(objschedtags, sqlchemy.AND(sqlchemy.Equals(objschedtags.Field(jointMan.GetMasterIdKey(jointMan)), objs.Field("id")), sqlchemy.IsFalse(objschedtags.Field("deleted")))) - q = q.Filter(sqlchemy.IsTrue(objs.Field("enabled"))) + // q = q.Filter(sqlchemy.IsTrue(objs.Field("enabled"))) q = q.Filter(sqlchemy.Equals(objschedtags.Field("schedtag_id"), self.Id)) return q } @@ -379,7 +379,8 @@ func (self *SSchedtag) GetJointManager() ISchedtagJointManager { } func (self *SSchedtag) GetObjectCount() (int, error) { - return self.GetJointManager().Query().Equals("schedtag_id", self.Id).CountWithError() + q := self.GetObjectQuery() + return q.CountWithError() } func (self *SSchedtag) getSchedPoliciesCount() (int, error) {