From 2dd27d3011966fe1eab9d73a59a02c898aa6bd29 Mon Sep 17 00:00:00 2001 From: Yousong Zhou Date: Tue, 5 Nov 2019 03:05:46 +0000 Subject: [PATCH] fileutils: SReadSeeker: fix closing tmpfile fd --- pkg/util/fileutils2/seeker.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/util/fileutils2/seeker.go b/pkg/util/fileutils2/seeker.go index cff1ed7813..1b086b6aca 100644 --- a/pkg/util/fileutils2/seeker.go +++ b/pkg/util/fileutils2/seeker.go @@ -39,7 +39,6 @@ func NewReadSeeker(reader io.Reader, size int64) (*SReadSeeker, error) { if err != nil { return nil, errors.Wrap(err, "TempFile") } - log.Debugf("use tmpfile %s", tmpfile.Name()) return &SReadSeeker{ reader: reader, readerOffset: 0, @@ -91,5 +90,6 @@ func (s *SReadSeeker) Seek(offset int64, whence int) (int64, error) { } func (s *SReadSeeker) Close() error { - return os.Remove(s.tmpFile.Name()) + defer os.Remove(s.tmpFile.Name()) + return s.tmpFile.Close() }