From adedad8e66145c9d66d3ac7c8e0c24e6b390938f Mon Sep 17 00:00:00 2001
From: ioito <qu_xuan@icloud.com>
Date: Thu, 20 Jun 2019 11:02:50 +0800
Subject: [PATCH] fix delete rules failure

---
 pkg/util/zstack/securitygroup.go | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/pkg/util/zstack/securitygroup.go b/pkg/util/zstack/securitygroup.go
index 668f0137f0..7a266d90e0 100644
--- a/pkg/util/zstack/securitygroup.go
+++ b/pkg/util/zstack/securitygroup.go
@@ -247,8 +247,15 @@ func (region *SRegion) AddSecurityGroupRule(secgroupId string, rules []secrules.
 }
 
 func (region *SRegion) DeleteSecurityGroupRules(ruleIds []string) error {
-	resource := fmt.Sprintf("security-groups/rules?ruleUuids=%s", strings.Join(ruleIds, ","))
-	return region.client.delete(resource, "", "")
+	if len(ruleIds) > 0 {
+		ids := []string{}
+		for _, ruleId := range ruleIds {
+			ids = append(ids, fmt.Sprintf("ruleUuids=%s", ruleId))
+		}
+		resource := fmt.Sprintf("security-groups/rules?%s", strings.Join(ids, "&"))
+		return region.client.delete(resource, "", "")
+	}
+	return nil
 }
 
 func (region *SRegion) CreateSecurityGroup(name, desc string) (*SSecurityGroup, error) {