From 97f1d1c150f93292234761642e7863b19214aa58 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B1=88=E8=BD=A9?= <quxuan@yunionyun.com>
Date: Thu, 15 Nov 2018 11:01:33 +0800
Subject: [PATCH] =?UTF-8?q?=E9=81=BF=E5=85=8D=E8=A6=86=E7=9B=96=E6=9C=AC?=
 =?UTF-8?q?=E5=9C=B0templateId?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 pkg/compute/guestdrivers/aws.go    | 45 +++++-------------------------
 pkg/compute/guestdrivers/qcloud.go |  2 +-
 2 files changed, 8 insertions(+), 39 deletions(-)

diff --git a/pkg/compute/guestdrivers/aws.go b/pkg/compute/guestdrivers/aws.go
index e0bd2ef7bd..76449f0b64 100644
--- a/pkg/compute/guestdrivers/aws.go
+++ b/pkg/compute/guestdrivers/aws.go
@@ -69,43 +69,6 @@ func (self *SAwsGuestDriver) ValidateCreateData(ctx context.Context, userCred mc
 	return self.SManagedVirtualizedGuestDriver.ValidateCreateData(ctx, userCred, data)
 }
 
-func fetchAwsIVMinfo(desc SManagedVMCreateConfig, iVM cloudprovider.ICloudVM, guestId string) *jsonutils.JSONDict {
-	data := jsonutils.NewDict()
-	data.Add(jsonutils.NewString(iVM.GetOSType()), "os")
-	if len(desc.OsDistribution) > 0 {
-		data.Add(jsonutils.NewString(desc.OsDistribution), "distro")
-	}
-	if len(desc.OsVersion) > 0 {
-		data.Add(jsonutils.NewString(desc.OsVersion), "version")
-	}
-
-	idisks, err := iVM.GetIDisks()
-
-	if err != nil {
-		log.Errorf("GetiDisks error %s", err)
-	} else {
-		diskInfo := make([]SDiskInfo, len(idisks))
-		for i := 0; i < len(idisks); i += 1 {
-			dinfo := SDiskInfo{}
-			dinfo.Uuid = idisks[i].GetGlobalId()
-			dinfo.Size = idisks[i].GetDiskSizeMB()
-			dinfo.DiskType = idisks[i].GetDiskType()
-			if metaData := idisks[i].GetMetadata(); metaData != nil {
-				dinfo.Metadata = make(map[string]string, 0)
-				if err := metaData.Unmarshal(dinfo.Metadata); err != nil {
-					log.Errorf("Get disk %s metadata info error: %v", idisks[i].GetName(), err)
-				}
-			}
-			diskInfo[i] = dinfo
-		}
-		data.Add(jsonutils.Marshal(&diskInfo), "disks")
-	}
-
-	data.Add(jsonutils.NewString(iVM.GetGlobalId()), "uuid")
-	data.Add(iVM.GetMetadata(), "metadata")
-	return data
-}
-
 func (self *SAwsGuestDriver) RequestDeployGuestOnHost(ctx context.Context, guest *models.SGuest, host *models.SHost, task taskman.ITask) error {
 	config := guest.GetDeployConfigOnHost(ctx, host, task.GetParams())
 	log.Debugf("RequestDeployGuestOnHost: %s", config)
@@ -171,7 +134,7 @@ func (self *SAwsGuestDriver) RequestDeployGuestOnHost(ctx context.Context, guest
 				return nil, err
 			}
 
-			data := fetchAwsIVMinfo(desc, iVM, guest.Id)
+			data := fetchIVMinfo(desc, iVM, guest.Id, "root", passwd, action)
 			return data, nil
 		})
 	case "deploy":
@@ -279,6 +242,12 @@ func (self *SAwsGuestDriver) OnGuestDeployTaskDataReceived(ctx context.Context,
 				disk.ExternalId = diskInfo[i].Uuid
 				disk.DiskType = diskInfo[i].DiskType
 				disk.Status = models.DISK_READY
+				disk.BillingType = diskInfo[i].BillingType
+				disk.FsFormat = diskInfo[i].FsFromat
+				disk.AutoDelete = true
+				//disk.TemplateId = diskInfo[i].TemplateId
+				disk.DiskFormat = diskInfo[i].DiskFormat
+				disk.ExpiredAt = diskInfo[i].ExpiredAt
 				if len(diskInfo[i].Metadata) > 0 {
 					for key, value := range diskInfo[i].Metadata {
 						if err := disk.SetMetadata(ctx, key, value, task.GetUserCred()); err != nil {
diff --git a/pkg/compute/guestdrivers/qcloud.go b/pkg/compute/guestdrivers/qcloud.go
index ef0dbc6e6d..9c523c085c 100644
--- a/pkg/compute/guestdrivers/qcloud.go
+++ b/pkg/compute/guestdrivers/qcloud.go
@@ -299,7 +299,7 @@ func (self *SQcloudGuestDriver) OnGuestDeployTaskDataReceived(ctx context.Contex
 				disk.BillingType = diskInfo[i].BillingType
 				disk.FsFormat = diskInfo[i].FsFromat
 				disk.AutoDelete = true
-				disk.TemplateId = diskInfo[i].TemplateId
+				//disk.TemplateId = diskInfo[i].TemplateId
 				disk.DiskFormat = diskInfo[i].DiskFormat
 				disk.ExpiredAt = diskInfo[i].ExpiredAt
 				if len(diskInfo[i].Metadata) > 0 {