From 115a09dcbb8207f0daaa027b7498ccf6c30c2aa4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=B1=88=E8=BD=A9?= Date: Tue, 30 Jul 2024 14:41:48 +0800 Subject: [PATCH] =?UTF-8?q?fix(cloudmon):=20=E9=81=BF=E5=85=8D=E4=BA=A7?= =?UTF-8?q?=E7=94=9F=E5=A4=A7=E9=87=8F=E6=93=8D=E4=BD=9C=E6=97=A5=E5=BF=97?= =?UTF-8?q?=20(#20918)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- pkg/cloudmon/resources/resources.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/cloudmon/resources/resources.go b/pkg/cloudmon/resources/resources.go index 14149c8c9a..9055d5ec41 100644 --- a/pkg/cloudmon/resources/resources.go +++ b/pkg/cloudmon/resources/resources.go @@ -672,7 +672,9 @@ func (res *SResources) CollectMetrics(ctx context.Context, userCred mcclient.Tok succ := true msgs := make([]string, 0) defer func() { - logclient.AddActionLogWithContext(ctx, &sMetricProvider{manager}, logclient.ACT_COLLECT_METRICS, strings.Join(msgs, ";"), userCred, succ) + if len(msgs) > 0 { + logclient.AddActionLogWithContext(ctx, &sMetricProvider{manager}, logclient.ACT_COLLECT_METRICS, strings.Join(msgs, ";"), userCred, succ) + } wg.Done() <-ch }() @@ -680,7 +682,6 @@ func (res *SResources) CollectMetrics(ctx context.Context, userCred mcclient.Tok if strings.Contains(strings.ToLower(options.Options.SkipMetricPullProviders), strings.ToLower(manager.Provider)) { logmsg := fmt.Sprintf("skip %s metric pull with options: %s", manager.Provider, options.Options.SkipMetricPullProviders) log.Infoln(logmsg) - msgs = append(msgs, logmsg) return } @@ -696,7 +697,6 @@ func (res *SResources) CollectMetrics(ctx context.Context, userCred mcclient.Tok if !driver.IsSupportMetrics() { logmsg := fmt.Sprintf("%s not support metrics, skip", driver.GetProvider()) log.Infoln(logmsg) - msgs = append(msgs, logmsg) return }