From 0b09372ffae3258fb392877b4baf642e2f4b73a5 Mon Sep 17 00:00:00 2001 From: TangBin Date: Wed, 31 Oct 2018 17:07:53 +0800 Subject: [PATCH] bugfix --- pkg/util/aws/utils.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/util/aws/utils.go b/pkg/util/aws/utils.go index 2e0bc338ea..293c50318a 100644 --- a/pkg/util/aws/utils.go +++ b/pkg/util/aws/utils.go @@ -244,9 +244,9 @@ func AwsIpPermissionToYunion(direction secrules.TSecurityRuleDirection, p ec2.Ip isAllPorts := isAwsPermissionAllPorts(p) protocol := awsProtocolToYunion(p) for _, ip := range p.IpRanges { - ipNet := strings.Split(*ip.CidrIp, "/") - if len(ipNet) != 2 { - log.Debugf("AwsIpPermissionToYunion ignored IPV4 rule: %s", *ip.CidrIp) + _, ipNet, err := net.ParseCIDR(*ip.CidrIp) + if err != nil { + log.Errorf("ParseCIDR failed, ignored IPV4 rule: %s", *ip.CidrIp) continue } @@ -254,7 +254,7 @@ func AwsIpPermissionToYunion(direction secrules.TSecurityRuleDirection, p ec2.Ip if isAllPorts { rule = secrules.SecurityRule{ Action: secrules.SecurityRuleAllow, - IPNet: &net.IPNet{net.IP(ipNet[0]), net.IPMask(ipNet[1])}, + IPNet: ipNet, Protocol: protocol, Direction: direction, Priority: 1, @@ -263,7 +263,7 @@ func AwsIpPermissionToYunion(direction secrules.TSecurityRuleDirection, p ec2.Ip } else { rule = secrules.SecurityRule{ Action: secrules.SecurityRuleAllow, - IPNet: &net.IPNet{net.IP(ipNet[0]), net.IPMask(ipNet[1])}, + IPNet: ipNet, Protocol: protocol, Direction: direction, Priority: 1,