From edf5e5eed82768063a1f92e663ca348f7e56d9ab Mon Sep 17 00:00:00 2001 From: Wroud Date: Mon, 5 Oct 2020 02:37:24 +0300 Subject: [PATCH] chore: linter improvements --- webapp/.eslintrc.js | 36 +++++++++++++++++++ .../src/Administration/Administration.tsx | 2 +- .../src/Administration/DrawerItem.tsx | 16 +++++---- .../AdministrationScreen.tsx | 2 +- .../ConfigurationWizardScreen.tsx | 4 +-- .../Pages/Finish/FinishPageDrawerItem.tsx | 6 ++-- .../ServerConfigurationDrawerItem.tsx | 4 +-- .../ServerConfigurationForm.tsx | 4 +-- .../Pages/Welcome/WelcomeDrawerItem.tsx | 6 ++-- .../Pages/Welcome/WelcomePage.tsx | 6 ++-- .../ConfigurationWizard/WizardStepper.tsx | 2 +- .../packages/core-app/src/AppScreen/Main.tsx | 2 +- .../core-app/src/AppScreen/RightArea.tsx | 2 +- webapp/packages/core-app/src/Body.tsx | 2 +- .../src/NavigationTree/NavigationTree.tsx | 8 ++--- .../NavigationNode/NavigationNode.tsx | 2 +- .../NavigationNodeChildren.tsx | 2 +- .../NavigationTreeNode/NavigationTreeNode.tsx | 3 +- .../ConnectionSelector/ConnectionSelector.tsx | 2 +- .../packages/core-app/src/TopNavBar/Logo.tsx | 2 +- .../src/TopNavBar/MainMenu/MainMenu.tsx | 2 +- .../src/TopNavBar/shared/TopMenuItem.tsx | 8 +++-- .../src/shared/InlineEditor/EditorDialog.tsx | 4 +-- .../src/shared/InlineEditor/InlineEditor.tsx | 6 ++-- .../NavigationTabsBar/NavigationTabsBar.tsx | 4 +-- .../NavigationTabsBar/Tabs/TabHandlerTab.tsx | 2 +- .../LogEntry/LogEntryDetailsDialog.tsx | 2 +- webapp/packages/core-blocks/src/Button.tsx | 2 +- .../core-blocks/src/FormControls/Checkbox.tsx | 2 +- .../core-blocks/src/FormControls/Combobox.tsx | 2 +- .../src/FormControls/InputField.tsx | 2 +- .../core-blocks/src/FormControls/Radio.tsx | 6 ++-- .../src/FormControls/ShadowInput.tsx | 5 +-- .../src/FormControls/SubmittingForm.tsx | 2 +- .../core-blocks/src/FormControls/Switch.tsx | 4 +-- .../packages/core-blocks/src/IconOrImage.tsx | 2 +- .../core-blocks/src/Icons/CheckCircle.tsx | 4 +-- .../core-blocks/src/Icons/Configuration.tsx | 2 +- .../packages/core-blocks/src/Icons/Cross.tsx | 2 +- .../packages/core-blocks/src/Icons/Frown.tsx | 2 +- .../src/ItemList/ItemListSearch.tsx | 2 +- .../core-blocks/src/ItemList/ListItem.tsx | 2 +- .../core-blocks/src/Loader/Loader.tsx | 10 ++++-- .../ObjectPropertyInfoForm.tsx | 4 +-- .../src/PropertiesTable/PropertiesTable.tsx | 4 +-- .../src/PropertiesTable/PropertyItem.tsx | 6 ++-- .../src/SanitizedHTML/SanitizedHTML.tsx | 2 +- .../packages/core-blocks/src/Split/Pane.tsx | 2 +- .../packages/core-blocks/src/Split/Split.tsx | 2 +- .../packages/core-blocks/src/StaticImage.tsx | 2 +- .../core-blocks/src/Table/TableItem.tsx | 2 +- .../core-blocks/src/Table/TableItemExpand.tsx | 2 +- .../core-blocks/src/Table/TableItemSelect.tsx | 2 +- .../packages/core-blocks/src/Tabs/Tab/Tab.tsx | 4 +-- .../core-blocks/src/Tabs/TabsBox/TabsBox.tsx | 2 +- .../src/Tabs/TabsBox/TabsBoxFromArray.tsx | 4 +-- .../Tabs/VerticalTabs/VerticalTabPanel.tsx | 2 +- .../src/Tabs/VerticalTabs/VerticalTabs.tsx | 2 +- .../ConnectionAccess/ConnectionAccess.tsx | 14 ++++---- .../ConnectionForm/ConnectionForm.tsx | 5 ++- .../ConnectionForm/Options/Options.tsx | 4 +-- .../ConnectionForm/Options/ParametersForm.tsx | 2 +- .../Connections/ConnectionsAdministration.tsx | 4 +-- .../Connections/ConnectionsDrawerItem.tsx | 4 +-- .../ConnectionsTable/Connection.tsx | 4 +-- .../ConnectionsTable/ConnectionEdit.tsx | 2 +- .../ConnectionsTable/ConnectionsTable.tsx | 10 +++--- .../CreateConnection/CreateConnection.tsx | 12 +++---- .../CreateConnection/CustomConnection.tsx | 4 +-- .../Connections/CreateConnection/Database.tsx | 2 +- .../Connections/CreateConnection/Driver.tsx | 2 +- .../CreateConnection/DriverList.tsx | 4 +-- .../DatabaseAuthDialog/DBAuthDialogFooter.tsx | 2 +- .../DatabaseAuthDialog/DatabaseAuthDialog.tsx | 4 +-- webapp/packages/core-di/src/IApp.ts | 2 +- webapp/packages/core-di/src/InjectionToken.ts | 4 ++- webapp/packages/core-di/src/PluginManifest.ts | 2 +- .../packages/core-di/src/entities/Entity.ts | 6 ++-- .../packages/core-di/src/inversifyWrapper.ts | 5 ++- .../src/CommonDialog/ConfirmationDialog.tsx | 10 +++--- .../src/CommonDialog/DialogsPortal.tsx | 2 +- .../src/Menu/MenuPanel/MenuTrigger.tsx | 17 ++++----- 82 files changed, 206 insertions(+), 155 deletions(-) diff --git a/webapp/.eslintrc.js b/webapp/.eslintrc.js index 792fc51705..23c6e97778 100644 --- a/webapp/.eslintrc.js +++ b/webapp/.eslintrc.js @@ -18,14 +18,17 @@ module.exports = { 'import/parsers': { '@typescript-eslint/parser': ['.ts', '.tsx'], }, + 'import/resolver': { typescript: { alwaysTryTypes: true, }, }, + typescript: { directory: './', }, + react: { createClass: 'createReactClass', pragma: 'React', @@ -42,6 +45,39 @@ module.exports = { 'react/display-name': 'off', 'react/jsx-no-literals': 'off', 'react/react-in-jsx-scope': 'off', + 'react/jsx-max-props-per-line': [1, { "when": "multiline" }], + 'react/jsx-closing-bracket-location': 'error', + 'react/jsx-closing-tag-location': 'error', + 'react/jsx-tag-spacing': ['error', { + "closingSlash": "never", + "beforeSelfClosing": "always", + "afterOpening": "never", + "beforeClosing": "never" + }], + 'react/jsx-boolean-value': 'error', + 'react/jsx-wrap-multilines': ['error', { + "declaration": "parens-new-line", + "assignment": "parens-new-line", + "return": "parens-new-line", + "arrow": "parens-new-line", + "condition": "parens-new-line", + "logical": "parens-new-line", + "prop": "parens-new-line" + }], + 'react/self-closing-comp': ["error"], + 'react/jsx-sort-props': ['error', { + "callbacksLast": true, + "shorthandLast": true, + "ignoreCase": true, + "noSortAlphabetically": true, + "reservedFirst": true, + }], + 'react/destructuring-assignment': ['error'], + 'react/jsx-curly-brace-presence': ['error', "never"], + 'react/jsx-curly-newline': ['error'], + 'react/jsx-curly-spacing': ['error', { "when": "never", "children": true }], + 'react/jsx-equals-spacing': ['error', 'never'], + 'react/jsx-first-prop-new-line': ['warn', 'multiline'], 'brace-style': 'off', // prefer 1tbs or stroustrup styles, avoid allman style 'operator-linebreak': 'warn', 'consistent-return': 'off', diff --git a/webapp/packages/core-administration/src/Administration/Administration.tsx b/webapp/packages/core-administration/src/Administration/Administration.tsx index 6b5013bd1a..386e728595 100644 --- a/webapp/packages/core-administration/src/Administration/Administration.tsx +++ b/webapp/packages/core-administration/src/Administration/Administration.tsx @@ -88,9 +88,9 @@ export const Administration = observer(function Administration({ ))} diff --git a/webapp/packages/core-administration/src/Administration/DrawerItem.tsx b/webapp/packages/core-administration/src/Administration/DrawerItem.tsx index 73871c441f..21f195a152 100644 --- a/webapp/packages/core-administration/src/Administration/DrawerItem.tsx +++ b/webapp/packages/core-administration/src/Administration/DrawerItem.tsx @@ -21,11 +21,13 @@ export const DrawerItem = observer(function DrawerItem({ const disabled = configurationWizard && !configurationWizardService.isStepAvailable(item.name); - return ; + return ( + + ); }); diff --git a/webapp/packages/core-administration/src/AdministrationScreen/AdministrationScreen.tsx b/webapp/packages/core-administration/src/AdministrationScreen/AdministrationScreen.tsx index 0a8341076a..a916bad7b6 100644 --- a/webapp/packages/core-administration/src/AdministrationScreen/AdministrationScreen.tsx +++ b/webapp/packages/core-administration/src/AdministrationScreen/AdministrationScreen.tsx @@ -21,7 +21,7 @@ import { AdministrationTopAppBar } from './AdministrationTopAppBar/Administratio export const AdministrationScreen = observer(function AdministrationScreen() { const administrationScreenService = useService(AdministrationScreenService); if (!usePermission(EAdminPermission.admin)) { - return ; + return ; } const handleSelect = useCallback( diff --git a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/ConfigurationWizardScreen.tsx b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/ConfigurationWizardScreen.tsx index 9766b3b8f6..83da8fbb7d 100644 --- a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/ConfigurationWizardScreen.tsx +++ b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/ConfigurationWizardScreen.tsx @@ -24,7 +24,7 @@ export const ConfigurationWizardScreen = observer(function ConfigurationWizardSc const administrationItemService = useService(AdministrationItemService); const administrationScreenService = useService(AdministrationScreenService); if (!usePermission(EAdminPermission.admin)) { - return ; + return ; } const handleSelect = useCallback( @@ -39,10 +39,10 @@ export const ConfigurationWizardScreen = observer(function ConfigurationWizardSc <> diff --git a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Finish/FinishPageDrawerItem.tsx b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Finish/FinishPageDrawerItem.tsx index 1b8f49fe40..31b4fc3be8 100644 --- a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Finish/FinishPageDrawerItem.tsx +++ b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Finish/FinishPageDrawerItem.tsx @@ -25,12 +25,12 @@ export const FinishPageDrawerItem = observer(function FinishPageDrawerItem({ return styled(useStyles(...style))( onSelect(item.name)} disabled={disabled || (item.configurationWizardOptions?.isDisabled && item.configurationWizardOptions.isDisabled())} + onOpen={() => onSelect(item.name)} > - - + + ); }); diff --git a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/ServerConfiguration/ServerConfigurationDrawerItem.tsx b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/ServerConfiguration/ServerConfigurationDrawerItem.tsx index a3dceb7a41..63af1ae1b3 100644 --- a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/ServerConfiguration/ServerConfigurationDrawerItem.tsx +++ b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/ServerConfiguration/ServerConfigurationDrawerItem.tsx @@ -18,9 +18,9 @@ export function ServerConfigurationDrawerItem({ item, onSelect, style, disabled, }: AdministrationItemDrawerProps) { return styled(useStyles(...style))( - onSelect(item.name)} disabled={disabled}> + onSelect(item.name)}> - + ); } diff --git a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/ServerConfiguration/ServerConfigurationForm.tsx b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/ServerConfiguration/ServerConfigurationForm.tsx index 23c4995242..29228a173a 100644 --- a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/ServerConfiguration/ServerConfigurationForm.tsx +++ b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/ServerConfiguration/ServerConfigurationForm.tsx @@ -70,7 +70,7 @@ export const ServerConfigurationForm = observer(function ServerConfigurationForm }, [service]); return styled(useStyles(formStyles, boxStyles))( - + @@ -135,9 +135,9 @@ export const ServerConfigurationForm = observer(function ServerConfigurationForm name="authenticationEnabled" state={serverConfig} description={translate('administration_configuration_wizard_configuration_authentication_description')} - onChange={onChange} mod={['primary']} long + onChange={onChange} > {translate('administration_configuration_wizard_configuration_authentication')} diff --git a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Welcome/WelcomeDrawerItem.tsx b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Welcome/WelcomeDrawerItem.tsx index ea177acf35..df64b42109 100644 --- a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Welcome/WelcomeDrawerItem.tsx +++ b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Welcome/WelcomeDrawerItem.tsx @@ -18,9 +18,9 @@ export function WelcomeDrawerItem({ item, onSelect, style, disabled, }: AdministrationItemDrawerProps) { return styled(useStyles(...style))( - onSelect(item.name)} disabled={disabled}> - - + onSelect(item.name)}> + + ); } diff --git a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Welcome/WelcomePage.tsx b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Welcome/WelcomePage.tsx index d8ab1c3ab5..c161b8791e 100644 --- a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Welcome/WelcomePage.tsx +++ b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/Pages/Welcome/WelcomePage.tsx @@ -52,9 +52,9 @@ export function WelcomePage() { -

-

- +

+

+
diff --git a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/WizardStepper.tsx b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/WizardStepper.tsx index fc42b83bbb..c139df892c 100644 --- a/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/WizardStepper.tsx +++ b/webapp/packages/core-administration/src/AdministrationScreen/ConfigurationWizard/WizardStepper.tsx @@ -70,8 +70,8 @@ export const WizardStepper = observer(function WizardStepper() { diff --git a/webapp/packages/core-app/src/AppScreen/Main.tsx b/webapp/packages/core-app/src/AppScreen/Main.tsx index 8e71148270..a4f4554ddc 100644 --- a/webapp/packages/core-app/src/AppScreen/Main.tsx +++ b/webapp/packages/core-app/src/AppScreen/Main.tsx @@ -46,7 +46,7 @@ export function Main() { return styled(useStyles(mainStyles, splitStyles))( - + diff --git a/webapp/packages/core-app/src/AppScreen/RightArea.tsx b/webapp/packages/core-app/src/AppScreen/RightArea.tsx index 2363eb5969..ba158aa6f9 100644 --- a/webapp/packages/core-app/src/AppScreen/RightArea.tsx +++ b/webapp/packages/core-app/src/AppScreen/RightArea.tsx @@ -46,7 +46,7 @@ export const RightArea = observer(function RightArea() { {controller.isActive && } - + diff --git a/webapp/packages/core-app/src/Body.tsx b/webapp/packages/core-app/src/Body.tsx index 9d7eb46a7f..ffdae7df5b 100644 --- a/webapp/packages/core-app/src/Body.tsx +++ b/webapp/packages/core-app/src/Body.tsx @@ -37,7 +37,7 @@ export const Body = observer(function Body() { }); return styled(useStyles(bodyStyles))( - + {Screen && } diff --git a/webapp/packages/core-app/src/NavigationTree/NavigationTree.tsx b/webapp/packages/core-app/src/NavigationTree/NavigationTree.tsx index 18a25f5aad..48c8a99f15 100644 --- a/webapp/packages/core-app/src/NavigationTree/NavigationTree.tsx +++ b/webapp/packages/core-app/src/NavigationTree/NavigationTree.tsx @@ -59,7 +59,7 @@ export const NavigationTree = observer(function NavigationTree() { if (nodeChildren.isLoading) { return styled(navigationTreeStyles)(
- +
); } @@ -68,7 +68,7 @@ export const NavigationTree = observer(function NavigationTree() {
- No connections.
+ No connections.
Use the top menu to setup connection to your database.
@@ -77,9 +77,9 @@ export const NavigationTree = observer(function NavigationTree() { } return styled(navigationTreeStyles)( - + {nodeChildren.children.map(id => ( - + ))} ); diff --git a/webapp/packages/core-app/src/NavigationTree/NavigationTreeNode/NavigationNode/NavigationNode.tsx b/webapp/packages/core-app/src/NavigationTree/NavigationTreeNode/NavigationNode/NavigationNode.tsx index 310d361b55..5f3b6a161f 100644 --- a/webapp/packages/core-app/src/NavigationTree/NavigationTreeNode/NavigationNode/NavigationNode.tsx +++ b/webapp/packages/core-app/src/NavigationTree/NavigationTreeNode/NavigationNode/NavigationNode.tsx @@ -75,10 +75,10 @@ export const NavigationNode = observer(function NavigationNode({