From e1908dfa4aaa0454ce3cf403358214d947c12ce4 Mon Sep 17 00:00:00 2001 From: Naumov Alexey Date: Tue, 28 Sep 2021 14:47:17 +0300 Subject: [PATCH 1/3] fix(core-dialogs): CB-1286 add ConfirmationDialogDelete, small ui changes --- .../src/TopNavBar/shared/topMenuStyles.ts | 3 +++ .../NodesManager/NavNodeContextMenuService.ts | 7 ++---- .../ConnectionsAdministrationController.ts | 4 ++-- .../src/ConnectionsManagerService.ts | 4 ++-- .../CommonDialog/CommonDialogWrapper.tsx | 2 +- .../src/CommonDialog/CommonDialog/styles.ts | 17 ++++++++++---- .../CommonDialog/ConfirmationDialogDelete.tsx | 23 +++++++++++++++++++ webapp/packages/core-dialogs/src/index.ts | 1 + .../useConfigurationsTable.tsx | 4 ++-- .../Roles/RolesTable/useRolesTable.tsx | 4 ++-- .../Users/UserForm/ConnectionAccess.tsx | 5 +++- .../Users/UsersAdministrationController.ts | 4 ++-- .../src/Dialog/AuthDialog.tsx | 2 +- .../ObjectPropertyTableFooterService.ts | 5 ++-- 14 files changed, 60 insertions(+), 25 deletions(-) create mode 100644 webapp/packages/core-dialogs/src/CommonDialog/ConfirmationDialogDelete.tsx diff --git a/webapp/packages/core-app/src/TopNavBar/shared/topMenuStyles.ts b/webapp/packages/core-app/src/TopNavBar/shared/topMenuStyles.ts index d835506b17..11e3e76b23 100644 --- a/webapp/packages/core-app/src/TopNavBar/shared/topMenuStyles.ts +++ b/webapp/packages/core-app/src/TopNavBar/shared/topMenuStyles.ts @@ -24,6 +24,9 @@ export const topMenuStyles = composes( menu-box { background-color: #338ecc!important; } + menu-box menu-panel-item { + border-color: #ffffff !important; + } MenuTrigger { height: 100%; padding: 0 16px !important; diff --git a/webapp/packages/core-app/src/shared/NodesManager/NavNodeContextMenuService.ts b/webapp/packages/core-app/src/shared/NodesManager/NavNodeContextMenuService.ts index 175ab7fee1..4e57b91ee2 100644 --- a/webapp/packages/core-app/src/shared/NodesManager/NavNodeContextMenuService.ts +++ b/webapp/packages/core-app/src/shared/NodesManager/NavNodeContextMenuService.ts @@ -8,7 +8,7 @@ import { ConnectionInfoResource } from '@cloudbeaver/core-connections'; import { Bootstrap, injectable } from '@cloudbeaver/core-di'; -import { CommonDialogService, ConfirmationDialog, ContextMenuService, DialogueStateResult, IMenuPanel, RenameDialog } from '@cloudbeaver/core-dialogs'; +import { CommonDialogService, ConfirmationDialogDelete, ContextMenuService, DialogueStateResult, IMenuPanel, RenameDialog } from '@cloudbeaver/core-dialogs'; import { NotificationService } from '@cloudbeaver/core-events'; import { isNavigatorViewSettingsEqual, CONNECTION_NAVIGATOR_VIEW_SETTINGS, NavigatorViewSettings } from '@cloudbeaver/core-root'; @@ -206,7 +206,6 @@ export class NavNodeContextMenuService extends Bootstrap { this.contextMenuService.getRootMenuToken(), { id: 'rename', - icon: 'edit', title: 'ui_rename', isPresent: context => context.contextType === NavNodeContextMenuService.nodeContextType, isHidden: context => !context.data.node.features?.includes(ENodeFeature.canRename), @@ -250,12 +249,10 @@ export class NavNodeContextMenuService extends Bootstrap { const node = context.data.node; const nodeName = getNodeName(node); - const result = await this.commonDialogService.open(ConfirmationDialog, { + const result = await this.commonDialogService.open(ConfirmationDialogDelete, { title: 'ui_data_delete_confirmation', - subTitle: node.name, message: `You're going to delete "${nodeName}". Are you sure?`, confirmActionText: 'ui_delete', - icon: node.icon, }); if (result === DialogueStateResult.Rejected) { diff --git a/webapp/packages/core-connections/src/Administration/Connections/ConnectionsAdministrationController.ts b/webapp/packages/core-connections/src/Administration/Connections/ConnectionsAdministrationController.ts index 1ac1aa56f5..16e95ea1f6 100644 --- a/webapp/packages/core-connections/src/Administration/Connections/ConnectionsAdministrationController.ts +++ b/webapp/packages/core-connections/src/Administration/Connections/ConnectionsAdministrationController.ts @@ -9,7 +9,7 @@ import { observable, computed, makeObservable } from 'mobx'; import { injectable } from '@cloudbeaver/core-di'; -import { CommonDialogService, ConfirmationDialog, DialogueStateResult } from '@cloudbeaver/core-dialogs'; +import { CommonDialogService, ConfirmationDialogDelete, DialogueStateResult } from '@cloudbeaver/core-dialogs'; import { NotificationService } from '@cloudbeaver/core-events'; import { resourceKeyList } from '@cloudbeaver/core-sdk'; @@ -73,7 +73,7 @@ export class ConnectionsAdministrationController { .map(id => this.connectionsResource.get(id)?.name) .filter(Boolean); - const result = await this.commonDialogService.open(ConfirmationDialog, { + const result = await this.commonDialogService.open(ConfirmationDialogDelete, { title: 'ui_data_delete_confirmation', message: `You're going to delete these connections: ${connectionNames.map(name => `"${name}"`).join(', ')}. Are you sure?`, confirmActionText: 'ui_delete', diff --git a/webapp/packages/core-connections/src/ConnectionsManagerService.ts b/webapp/packages/core-connections/src/ConnectionsManagerService.ts index 2a5a010a51..893f206f62 100644 --- a/webapp/packages/core-connections/src/ConnectionsManagerService.ts +++ b/webapp/packages/core-connections/src/ConnectionsManagerService.ts @@ -10,7 +10,7 @@ import { Subject } from 'rxjs'; import { ProcessSnackbar } from '@cloudbeaver/core-blocks'; import { injectable } from '@cloudbeaver/core-di'; -import { CommonDialogService, ConfirmationDialog, DialogueStateResult } from '@cloudbeaver/core-dialogs'; +import { CommonDialogService, ConfirmationDialogDelete, DialogueStateResult } from '@cloudbeaver/core-dialogs'; import { NotificationService } from '@cloudbeaver/core-events'; import { Executor, IExecutionContextProvider, IExecutor } from '@cloudbeaver/core-executor'; @@ -70,7 +70,7 @@ export class ConnectionsManagerService { return; } - const result = await this.commonDialogService.open(ConfirmationDialog, { + const result = await this.commonDialogService.open(ConfirmationDialogDelete, { title: 'ui_data_delete_confirmation', message: `You're going to delete "${connection.name}" connection. Are you sure?`, confirmActionText: 'ui_delete', diff --git a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/CommonDialogWrapper.tsx b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/CommonDialogWrapper.tsx index 94cde2a689..f89020def7 100644 --- a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/CommonDialogWrapper.tsx +++ b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/CommonDialogWrapper.tsx @@ -81,7 +81,7 @@ export const CommonDialogWrapper = observer(function C )} - {subTitle && {translate(subTitle)}} + {subTitle && translate(subTitle)} diff --git a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts index e4564d21de..e25e7fbf72 100644 --- a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts +++ b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts @@ -76,12 +76,12 @@ export const commonDialogBaseStyle = composes( } &[|size=large] { min-width: 720px; - min-height: 468px; - max-height: max(100vh - 48px, 468px); + min-height: 490px; + max-height: max(100vh - 48px, 490px); &[|fixedSize] { width: 720px; - height: 468px; + height: 490px; } &[|fixedWidth] { width: 720px; @@ -90,12 +90,17 @@ export const commonDialogBaseStyle = composes( } header, dialog-body, footer { flex-shrink: 0; - padding: 24px; &[|no-padding] { padding: 0px; } } + dialog-body, footer { + padding: 24px; + } + header { + padding: 24px 24px 0; + } dialog-body { padding-top: 0px; padding-right: 0px; @@ -178,6 +183,10 @@ export const commonDialogBaseStyle = composes( sub-title { composes: theme-typography--caption from global; grid-column: 2; + min-height: 24px; + &:not(:empty) { + padding-bottom: 20px; + } } reject { cursor: pointer; diff --git a/webapp/packages/core-dialogs/src/CommonDialog/ConfirmationDialogDelete.tsx b/webapp/packages/core-dialogs/src/CommonDialog/ConfirmationDialogDelete.tsx new file mode 100644 index 0000000000..3305f0a8fe --- /dev/null +++ b/webapp/packages/core-dialogs/src/CommonDialog/ConfirmationDialogDelete.tsx @@ -0,0 +1,23 @@ +/* + * CloudBeaver - Cloud Database Manager + * Copyright (C) 2020-2021 DBeaver Corp and others + * + * Licensed under the Apache License, Version 2.0. + * you may not use this file except in compliance with the License. + */ + +import type { DialogComponent } from '../CommonDialog/CommonDialogService'; +import { ConfirmationDialog } from '../CommonDialog/ConfirmationDialog'; +import type { ConfirmationDialogPayload } from '../CommonDialog/ConfirmationDialog'; + +export const ConfirmationDialogDelete: DialogComponent = function ConfirmationDialogDelete({ + payload, + ...rest +}) { + return ( + + ); +}; diff --git a/webapp/packages/core-dialogs/src/index.ts b/webapp/packages/core-dialogs/src/index.ts index 4ae83c1656..31fbecb4c9 100644 --- a/webapp/packages/core-dialogs/src/index.ts +++ b/webapp/packages/core-dialogs/src/index.ts @@ -1,6 +1,7 @@ export * from './CommonDialog/CommonDialog/CommonDialogWrapper'; export * from './CommonDialog/CommonDialogService'; export * from './CommonDialog/ConfirmationDialog'; +export * from './CommonDialog/ConfirmationDialogDelete'; export * from './CommonDialog/RenameDialog'; export * from './CommonDialog/DialogsPortal'; diff --git a/webapp/packages/plugin-authentication/src/Administration/IdentityProviders/AuthConfigurationsTable/useConfigurationsTable.tsx b/webapp/packages/plugin-authentication/src/Administration/IdentityProviders/AuthConfigurationsTable/useConfigurationsTable.tsx index 7554cdedda..c249d84a35 100644 --- a/webapp/packages/plugin-authentication/src/Administration/IdentityProviders/AuthConfigurationsTable/useConfigurationsTable.tsx +++ b/webapp/packages/plugin-authentication/src/Administration/IdentityProviders/AuthConfigurationsTable/useConfigurationsTable.tsx @@ -11,7 +11,7 @@ import { computed, observable } from 'mobx'; import { AuthConfigurationsResource, compareAuthConfigurations } from '@cloudbeaver/core-authentication'; import { TableState, useObservableRef } from '@cloudbeaver/core-blocks'; import { useService } from '@cloudbeaver/core-di'; -import { CommonDialogService, ConfirmationDialog, DialogueStateResult } from '@cloudbeaver/core-dialogs'; +import { CommonDialogService, ConfirmationDialogDelete, DialogueStateResult } from '@cloudbeaver/core-dialogs'; import { NotificationService } from '@cloudbeaver/core-events'; import { AdminAuthProviderConfiguration, resourceKeyList } from '@cloudbeaver/core-sdk'; @@ -64,7 +64,7 @@ export function useConfigurationsTable(): Readonly { .map(id => resource.get(id)?.displayName) .filter(Boolean); - const result = await dialogService.open(ConfirmationDialog, { + const result = await dialogService.open(ConfirmationDialogDelete, { title: 'ui_data_delete_confirmation', message: `You're going to delete these configurations: ${configurationsNames.map(name => `"${name}"`).join(', ')}. Are you sure?`, confirmActionText: 'ui_delete', diff --git a/webapp/packages/plugin-authentication/src/Administration/Roles/RolesTable/useRolesTable.tsx b/webapp/packages/plugin-authentication/src/Administration/Roles/RolesTable/useRolesTable.tsx index b509d5af99..cfac852621 100644 --- a/webapp/packages/plugin-authentication/src/Administration/Roles/RolesTable/useRolesTable.tsx +++ b/webapp/packages/plugin-authentication/src/Administration/Roles/RolesTable/useRolesTable.tsx @@ -11,7 +11,7 @@ import { computed, observable } from 'mobx'; import { compareRoles, RoleInfo, RolesResource } from '@cloudbeaver/core-authentication'; import { TableState, useObservableRef } from '@cloudbeaver/core-blocks'; import { useService } from '@cloudbeaver/core-di'; -import { CommonDialogService, ConfirmationDialog, DialogueStateResult } from '@cloudbeaver/core-dialogs'; +import { CommonDialogService, ConfirmationDialogDelete, DialogueStateResult } from '@cloudbeaver/core-dialogs'; import { NotificationService } from '@cloudbeaver/core-events'; import { resourceKeyList } from '@cloudbeaver/core-sdk'; @@ -60,7 +60,7 @@ export function useRolesTable(): Readonly { return; } - const result = await dialogService.open(ConfirmationDialog, { + const result = await dialogService.open(ConfirmationDialogDelete, { title: 'ui_data_delete_confirmation', message: `You're going to delete these roles: ${deletionList.map(name => `"${name}"`).join(', ')}. Are you sure?`, confirmActionText: 'ui_delete', diff --git a/webapp/packages/plugin-authentication/src/Administration/Users/UserForm/ConnectionAccess.tsx b/webapp/packages/plugin-authentication/src/Administration/Users/UserForm/ConnectionAccess.tsx index a098a80d9c..d0b0bc1921 100644 --- a/webapp/packages/plugin-authentication/src/Administration/Users/UserForm/ConnectionAccess.tsx +++ b/webapp/packages/plugin-authentication/src/Administration/Users/UserForm/ConnectionAccess.tsx @@ -28,10 +28,13 @@ import type { IUserFormProps } from './UserFormService'; const styles = composes( css` Table { - composes: theme-background-surface theme-text-on-surface from global; + composes: theme-background-surface theme-text-on-surface theme-border-color-background from global; } `, css` + Table { + border: 1px solid; + } StaticImage { display: flex; width: 24px; diff --git a/webapp/packages/plugin-authentication/src/Administration/Users/UsersAdministrationController.ts b/webapp/packages/plugin-authentication/src/Administration/Users/UsersAdministrationController.ts index a23eca6acb..688c3bcfdd 100644 --- a/webapp/packages/plugin-authentication/src/Administration/Users/UsersAdministrationController.ts +++ b/webapp/packages/plugin-authentication/src/Administration/Users/UsersAdministrationController.ts @@ -10,7 +10,7 @@ import { observable, computed, makeObservable } from 'mobx'; import { AdminUser, AuthProvidersResource, AUTH_PROVIDER_LOCAL_ID, UsersResource } from '@cloudbeaver/core-authentication'; import { injectable, IInitializableController } from '@cloudbeaver/core-di'; -import { CommonDialogService, ConfirmationDialog, DialogueStateResult } from '@cloudbeaver/core-dialogs'; +import { CommonDialogService, ConfirmationDialogDelete, DialogueStateResult } from '@cloudbeaver/core-dialogs'; import { NotificationService } from '@cloudbeaver/core-events'; import { ErrorDetailsDialog } from '@cloudbeaver/core-notifications'; import { GQLErrorCatcher, resourceKeyList } from '@cloudbeaver/core-sdk'; @@ -92,7 +92,7 @@ export class UsersAdministrationController implements IInitializableController { return; } - const result = await this.commonDialogService.open(ConfirmationDialog, { + const result = await this.commonDialogService.open(ConfirmationDialogDelete, { title: 'ui_data_delete_confirmation', message: `You're going to delete these users: ${deletionList.map(name => `"${name}"`).join(', ')}. Are you sure?`, confirmActionText: 'ui_delete', diff --git a/webapp/packages/plugin-authentication/src/Dialog/AuthDialog.tsx b/webapp/packages/plugin-authentication/src/Dialog/AuthDialog.tsx index afb1c1a6dc..d9a2853818 100644 --- a/webapp/packages/plugin-authentication/src/Dialog/AuthDialog.tsx +++ b/webapp/packages/plugin-authentication/src/Dialog/AuthDialog.tsx @@ -93,7 +93,7 @@ export const AuthDialog: DialogComponent = observer(function const configurable = !!controller.provider?.configurable; const dialogTitle = `${controller.provider?.label || ''} ${translate('authentication_login_dialog_title')}`; - let subTitle: string | undefined; + let subTitle = controller.provider?.description; if (configurable) { subTitle = 'authentication_identity_provider_dialog_subtitle'; diff --git a/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectPropertyTable/ObjectPropertyTableFooterService.ts b/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectPropertyTable/ObjectPropertyTableFooterService.ts index 413e9885cc..fa564bd2ee 100644 --- a/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectPropertyTable/ObjectPropertyTableFooterService.ts +++ b/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectPropertyTable/ObjectPropertyTableFooterService.ts @@ -11,7 +11,7 @@ import type { TableState } from '@cloudbeaver/core-blocks'; import { injectable } from '@cloudbeaver/core-di'; import { ContextMenuService, IMenuContext, IContextMenuItem, IMenuItem, - CommonDialogService, ConfirmationDialog, DialogueStateResult + CommonDialogService, DialogueStateResult, ConfirmationDialogDelete } from '@cloudbeaver/core-dialogs'; import { NotificationService } from '@cloudbeaver/core-events'; import { resourceKeyList } from '@cloudbeaver/core-sdk'; @@ -57,11 +57,10 @@ export class ObjectPropertyTableFooterService { .filter(node => node.features?.includes(ENodeFeature.canDelete)); const nodeNames = nodes.map(getNodeName); - const result = await this.commonDialogService.open(ConfirmationDialog, { + const result = await this.commonDialogService.open(ConfirmationDialogDelete, { title: 'ui_data_delete_confirmation', message: `You're going to delete following items: "${nodeNames.join(', ')}". Are you sure?`, icon: '/icons/error_icon.svg', - bigIcon: true, confirmActionText: 'ui_delete', }); From bb66d6a382d62c2dcc0b41f0ea296727800257f4 Mon Sep 17 00:00:00 2001 From: Naumov Alexey Date: Tue, 28 Sep 2021 16:02:57 +0300 Subject: [PATCH 2/3] fix(core-dialogs): CB-1286 revert common dialog styles --- .../CommonDialog/CommonDialogWrapper.tsx | 2 +- .../src/CommonDialog/CommonDialog/styles.ts | 19 +++++-------------- .../Users/UserForm/ConnectionAccess.tsx | 5 +---- .../src/Dialog/AuthDialog.tsx | 4 ++++ 4 files changed, 11 insertions(+), 19 deletions(-) diff --git a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/CommonDialogWrapper.tsx b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/CommonDialogWrapper.tsx index f89020def7..94cde2a689 100644 --- a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/CommonDialogWrapper.tsx +++ b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/CommonDialogWrapper.tsx @@ -81,7 +81,7 @@ export const CommonDialogWrapper = observer(function C )} - {subTitle && translate(subTitle)} + {subTitle && {translate(subTitle)}} diff --git a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts index e25e7fbf72..553ecc4227 100644 --- a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts +++ b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts @@ -76,12 +76,12 @@ export const commonDialogBaseStyle = composes( } &[|size=large] { min-width: 720px; - min-height: 490px; - max-height: max(100vh - 48px, 490px); + min-height: 468px; + max-height: max(100vh - 48px, 468px); &[|fixedSize] { width: 720px; - height: 490px; + height: 468px; } &[|fixedWidth] { width: 720px; @@ -90,17 +90,12 @@ export const commonDialogBaseStyle = composes( } header, dialog-body, footer { flex-shrink: 0; - + padding: 24px; + &[|no-padding] { padding: 0px; } } - dialog-body, footer { - padding: 24px; - } - header { - padding: 24px 24px 0; - } dialog-body { padding-top: 0px; padding-right: 0px; @@ -183,10 +178,6 @@ export const commonDialogBaseStyle = composes( sub-title { composes: theme-typography--caption from global; grid-column: 2; - min-height: 24px; - &:not(:empty) { - padding-bottom: 20px; - } } reject { cursor: pointer; diff --git a/webapp/packages/plugin-authentication/src/Administration/Users/UserForm/ConnectionAccess.tsx b/webapp/packages/plugin-authentication/src/Administration/Users/UserForm/ConnectionAccess.tsx index d0b0bc1921..a098a80d9c 100644 --- a/webapp/packages/plugin-authentication/src/Administration/Users/UserForm/ConnectionAccess.tsx +++ b/webapp/packages/plugin-authentication/src/Administration/Users/UserForm/ConnectionAccess.tsx @@ -28,13 +28,10 @@ import type { IUserFormProps } from './UserFormService'; const styles = composes( css` Table { - composes: theme-background-surface theme-text-on-surface theme-border-color-background from global; + composes: theme-background-surface theme-text-on-surface from global; } `, css` - Table { - border: 1px solid; - } StaticImage { display: flex; width: 24px; diff --git a/webapp/packages/plugin-authentication/src/Dialog/AuthDialog.tsx b/webapp/packages/plugin-authentication/src/Dialog/AuthDialog.tsx index d9a2853818..ad38952228 100644 --- a/webapp/packages/plugin-authentication/src/Dialog/AuthDialog.tsx +++ b/webapp/packages/plugin-authentication/src/Dialog/AuthDialog.tsx @@ -31,6 +31,10 @@ const styles = composes( } `, css` + CommonDialogWrapper { + min-height: 490px !important; + max-height: max(100vh - 48px, 490px) !important; + } SubmittingForm { overflow: auto; &[|form] { From 19e0b807af8070d41d5f8c9c5b72a9389897f072 Mon Sep 17 00:00:00 2001 From: Naumov Alexey Date: Tue, 28 Sep 2021 16:06:02 +0300 Subject: [PATCH 3/3] fix(core-dialogs): CB-1286 code style --- .../core-dialogs/src/CommonDialog/CommonDialog/styles.ts | 2 +- .../ObjectPropertyTable/ObjectPropertyTableFooterService.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts index 553ecc4227..e4564d21de 100644 --- a/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts +++ b/webapp/packages/core-dialogs/src/CommonDialog/CommonDialog/styles.ts @@ -91,7 +91,7 @@ export const commonDialogBaseStyle = composes( header, dialog-body, footer { flex-shrink: 0; padding: 24px; - + &[|no-padding] { padding: 0px; } diff --git a/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectPropertyTable/ObjectPropertyTableFooterService.ts b/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectPropertyTable/ObjectPropertyTableFooterService.ts index fa564bd2ee..649782520e 100644 --- a/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectPropertyTable/ObjectPropertyTableFooterService.ts +++ b/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectPropertyTable/ObjectPropertyTableFooterService.ts @@ -60,7 +60,6 @@ export class ObjectPropertyTableFooterService { const result = await this.commonDialogService.open(ConfirmationDialogDelete, { title: 'ui_data_delete_confirmation', message: `You're going to delete following items: "${nodeNames.join(', ')}". Are you sure?`, - icon: '/icons/error_icon.svg', confirmActionText: 'ui_delete', });